Refactor changeset functions to impl classes#363
Draft
aiguofer wants to merge 4 commits into
Draft
Conversation
Each public changeset_* function now delegates to a private _Impl class. The class holds state (self._refactors, self._refactored, self._current_path) so helper methods append directly instead of threading entries through return values. Path accumulation via self._current_path eliminates manual prefix construction at call sites. Public function names and signatures are unchanged; refactor.py is untouched.
…iesImpl Rename to _restructure_owner_node and change return type from Tuple[CommentedMap, bool] to None. State is mutated directly on self._refactored and self._refactors, eliminating the tuple unpacking and redundant node reassignment in _process().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes made and why they were made. Link to any relevant issues or tickets.
Type of change
Checklist
uv run ruff check . --config pyproject.tomluv run ruff format --config pyproject.toml