fix sending RSA signature flag with a non RSA key

ddebin · ddebin · commit 70c657b98169 · 2026-04-13T20:59:52.000+02:00
diff --git a/src/lib/ssh_agent_client.ts b/src/lib/ssh_agent_client.ts
@@ -151,7 +151,7 @@ export class SSHAgentClient {
       let offset = writeHeader(req, Protocol.SSH2_AGENTC_SIGN_REQUEST)
       offset = writeString(req, key.raw, offset)
       offset = writeString(req, data, offset)
-      req.writeUInt32BE(this.rsaSignatureFlag, offset)
+      req.writeUInt32BE(key.type === 'ssh-rsa' ? this.rsaSignatureFlag : 0, offset)
       return req
     }
 

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ export class SSHAgentClient {`
`151`	`151`	`let offset = writeHeader(req, Protocol.SSH2_AGENTC_SIGN_REQUEST)`
`152`	`152`	`offset = writeString(req, key.raw, offset)`
`153`	`153`	`offset = writeString(req, data, offset)`
`154`		`- req.writeUInt32BE(this.rsaSignatureFlag, offset)`
	`154`	`+ req.writeUInt32BE(key.type === 'ssh-rsa' ? this.rsaSignatureFlag : 0, offset)`
`155`	`155`	`return req`
`156`	`156`	`}`
`157`	`157`