From 847f468148d170bff36969467828ee2ec4ee8d20 Mon Sep 17 00:00:00 2001 From: Dean Sharon Date: Mon, 9 Mar 2026 17:48:34 +0200 Subject: [PATCH] fix: correct file detection and skill availability check in code-review - Disambiguate TypeScript vs React file conditions to prevent LLM conflation (.ts/.tsx was being misread as .tsx/.jsx) - Switch skill availability check from Glob to Read (Glob doesn't expand ~ but Read does, causing false "not installed" for all optional language skills) --- plugins/devflow-code-review/commands/code-review-teams.md | 8 ++++---- plugins/devflow-code-review/commands/code-review.md | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/plugins/devflow-code-review/commands/code-review-teams.md b/plugins/devflow-code-review/commands/code-review-teams.md index c8627fa..a9d6866 100644 --- a/plugins/devflow-code-review/commands/code-review-teams.md +++ b/plugins/devflow-code-review/commands/code-review-teams.md @@ -38,9 +38,9 @@ Detect file types in diff to determine conditional reviews: | Condition | Adds Perspective | |-----------|-----------------| -| .ts/.tsx files | typescript | -| .tsx/.jsx files | react | -| .tsx/.jsx files | accessibility | +| Any .ts or .tsx files | typescript | +| .tsx or .jsx files (React components) | react | +| .tsx or .jsx files (React components) | accessibility | | .tsx/.jsx/.css/.scss files | frontend-design | | .go files | go | | .java files | java | @@ -50,7 +50,7 @@ Detect file types in diff to determine conditional reviews: | Dependency files changed | dependencies | | Docs or significant code | documentation | -**Skill availability check**: Language/ecosystem reviews (typescript, react, accessibility, frontend-design, go, java, python, rust) require their optional skill plugin to be installed. Before adding a conditional perspective, check if `~/.claude/skills/{focus}/SKILL.md` exists (use Glob). If the skill file doesn't exist, **skip that perspective** — the language plugin isn't installed. Non-language reviews (database, dependencies, documentation) use skills bundled with this plugin and are always available. +**Skill availability check**: Language/ecosystem reviews (typescript, react, accessibility, frontend-design, go, java, python, rust) require their optional skill plugin to be installed. Before adding a conditional perspective, use Read to check if `~/.claude/skills/{focus}/SKILL.md` exists. If Read returns an error (file not found), **skip that perspective** — the language plugin isn't installed. Non-language reviews (database, dependencies, documentation) use skills bundled with this plugin and are always available. ### Phase 2: Spawn Review Team diff --git a/plugins/devflow-code-review/commands/code-review.md b/plugins/devflow-code-review/commands/code-review.md index d2c3df2..86026ed 100644 --- a/plugins/devflow-code-review/commands/code-review.md +++ b/plugins/devflow-code-review/commands/code-review.md @@ -38,9 +38,9 @@ Detect file types in diff to determine conditional reviews: | Condition | Adds Review | |-----------|-------------| -| .ts/.tsx files | typescript | -| .tsx/.jsx files | react | -| .tsx/.jsx files | accessibility | +| Any .ts or .tsx files | typescript | +| .tsx or .jsx files (React components) | react | +| .tsx or .jsx files (React components) | accessibility | | .tsx/.jsx/.css/.scss files | frontend-design | | .go files | go | | .java files | java | @@ -50,7 +50,7 @@ Detect file types in diff to determine conditional reviews: | Dependency files changed | dependencies | | Docs or significant code | documentation | -**Skill availability check**: Language/ecosystem reviews (typescript, react, accessibility, frontend-design, go, java, python, rust) require their optional skill plugin to be installed. Before spawning a conditional Reviewer for these focuses, check if `~/.claude/skills/{focus}/SKILL.md` exists (use Glob). If the skill file doesn't exist, **skip that review** — the language plugin isn't installed. Non-language reviews (database, dependencies, documentation) use skills bundled with this plugin and are always available. +**Skill availability check**: Language/ecosystem reviews (typescript, react, accessibility, frontend-design, go, java, python, rust) require their optional skill plugin to be installed. Before spawning a conditional Reviewer for these focuses, use Read to check if `~/.claude/skills/{focus}/SKILL.md` exists. If Read returns an error (file not found), **skip that review** — the language plugin isn't installed. Non-language reviews (database, dependencies, documentation) use skills bundled with this plugin and are always available. ### Phase 2: Run Reviews (Parallel)