From a0bc46cdadfa1a8ca17309ff7a25c47c5f74c8c7 Mon Sep 17 00:00:00 2001
From: Esteban Ordano <esteban@decentraland.org>
Date: Fri, 13 Jan 2023 17:36:16 -0300
Subject: [PATCH 1/4] chore: test if duplicates are being sent

---
 packages/shared/comms/handlers.ts | 2 +-
 packages/shared/comms/peers.ts    | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/packages/shared/comms/handlers.ts b/packages/shared/comms/handlers.ts
index 7adfd07b2..0e8370f0b 100644
--- a/packages/shared/comms/handlers.ts
+++ b/packages/shared/comms/handlers.ts
@@ -161,7 +161,7 @@ function processProfileUpdatedMessage(message: Package<proto.AnnounceProfileVers
     peerTrackingInfo.lastProfileVersion = message.data.profileVersion
 
     // remove duplicates
-    ensureTrackingUniqueAndLatest(peerTrackingInfo)
+    ;[_, changed] = ensureTrackingUniqueAndLatest(peerTrackingInfo)
 
     const profileVersion = +message.data.profileVersion
 
diff --git a/packages/shared/comms/peers.ts b/packages/shared/comms/peers.ts
index bf7524206..2075a77bb 100644
--- a/packages/shared/comms/peers.ts
+++ b/packages/shared/comms/peers.ts
@@ -18,6 +18,10 @@ import * as rfc4 from '@dcl/protocol/out-ts/decentraland/kernel/comms/rfc4/comms
 const peerMap = new Map<string, PeerInformation>()
 export const avatarMessageObservable = new Observable<AvatarMessage>()
 
+avatarMessageObservable.subscribe((data) => {
+  console.log(`[avatarMessageObservable] ${JSON.stringify(data)}`)
+})
+
 export function getAllPeers() {
   return new Map(peerMap)
 }
@@ -185,11 +189,13 @@ export function removeAllPeers() {
  */
 export function ensureTrackingUniqueAndLatest(peer: PeerInformation) {
   let currentPeer = peer
+  let changed = false
 
   peerMap.forEach((info, address) => {
     if (info.ethereumAddress === currentPeer.ethereumAddress && address !== peer.ethereumAddress) {
       if (info.lastProfileVersion < currentPeer.lastProfileVersion) {
         removePeerByAddress(address)
+        changed = true
       } else if (info.lastProfileVersion > currentPeer.lastProfileVersion) {
         removePeerByAddress(currentPeer.ethereumAddress)
 
@@ -201,7 +207,7 @@ export function ensureTrackingUniqueAndLatest(peer: PeerInformation) {
     }
   })
 
-  return currentPeer
+  return [currentPeer, changed]
 }
 
 export function processAvatarVisibility(maxVisiblePeers: number, myAddress: string | undefined) {

From 8696fa6c3ab68d258b7293e5a90136b384c9ac6f Mon Sep 17 00:00:00 2001
From: Esteban Ordano <esteban@decentraland.org>
Date: Fri, 13 Jan 2023 17:40:14 -0300
Subject: [PATCH 2/4] chore: drop unchanged

---
 packages/shared/comms/handlers.ts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/packages/shared/comms/handlers.ts b/packages/shared/comms/handlers.ts
index 0e8370f0b..be7231a0d 100644
--- a/packages/shared/comms/handlers.ts
+++ b/packages/shared/comms/handlers.ts
@@ -162,6 +162,9 @@ function processProfileUpdatedMessage(message: Package<proto.AnnounceProfileVers
 
     // remove duplicates
     ;[_, changed] = ensureTrackingUniqueAndLatest(peerTrackingInfo)
+    if (!changed) {
+      return
+    }
 
     const profileVersion = +message.data.profileVersion
 

From 5f8b938304b6304afe1509baa811d5b865e82b73 Mon Sep 17 00:00:00 2001
From: Esteban Ordano <esteban@decentraland.org>
Date: Wed, 25 Jan 2023 02:14:58 +0100
Subject: [PATCH 3/4] Update handlers.ts

Signed-off-by: Esteban Ordano <esteban@decentraland.org>
---
 packages/shared/comms/handlers.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/shared/comms/handlers.ts b/packages/shared/comms/handlers.ts
index be7231a0d..b71ab6205 100644
--- a/packages/shared/comms/handlers.ts
+++ b/packages/shared/comms/handlers.ts
@@ -161,7 +161,7 @@ function processProfileUpdatedMessage(message: Package<proto.AnnounceProfileVers
     peerTrackingInfo.lastProfileVersion = message.data.profileVersion
 
     // remove duplicates
-    ;[_, changed] = ensureTrackingUniqueAndLatest(peerTrackingInfo)
+    const [_, changed] = ensureTrackingUniqueAndLatest(peerTrackingInfo)
     if (!changed) {
       return
     }

From 629ad9f5b8e6a6f29f36827960877be936145fdd Mon Sep 17 00:00:00 2001
From: Esteban Ordano <esteban@decentraland.org>
Date: Wed, 25 Jan 2023 02:15:48 +0100
Subject: [PATCH 4/4] Update peers.ts

Signed-off-by: Esteban Ordano <esteban@decentraland.org>
---
 packages/shared/comms/peers.ts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/packages/shared/comms/peers.ts b/packages/shared/comms/peers.ts
index 2075a77bb..c490fdff8 100644
--- a/packages/shared/comms/peers.ts
+++ b/packages/shared/comms/peers.ts
@@ -18,10 +18,6 @@ import * as rfc4 from '@dcl/protocol/out-ts/decentraland/kernel/comms/rfc4/comms
 const peerMap = new Map<string, PeerInformation>()
 export const avatarMessageObservable = new Observable<AvatarMessage>()
 
-avatarMessageObservable.subscribe((data) => {
-  console.log(`[avatarMessageObservable] ${JSON.stringify(data)}`)
-})
-
 export function getAllPeers() {
   return new Map(peerMap)
 }