09 10 feat sparkles adds xai service#135
Conversation
…thub.com/deeep-network/ansible_collections into 08-24-feat_sparkles_adds_hychain_service
…ithub.com/deeep-network/ansible_collections into 09-10-fear_sparkles_adds_autonomi_service
…_adds_xai_service
|
Can we remove Hychain from this PR and make it just the Xai node code? I think we should probably be merging this to a |
There was a problem hiding this comment.
This should be removed since it's out of scope for Xai.
There was a problem hiding this comment.
This should be removed since it's out of scope for Xai.
There was a problem hiding this comment.
This should be removed since it's out of scope for Xai.
| xai_version: 1.1.14 | ||
| xai_metrics_port: 33004 | ||
| xai_download_url: "https://github.com/xai-foundation/sentry/releases/latest/download/sentry-node-cli-linux.zip" |
There was a problem hiding this comment.
With the depin.core.installer the following should be updated.
xai_version: 1.1.14
xai_download_urls:
- "https://github.com/xai-foundation/sentry/releases/latest/download/sentry-node-cli-linux.zip"The following should be moved to depin/core/roles/metrics/default.yml
xai_metrics_port: 33004| xai_version: 1.1.14 | ||
| xai_metrics_port: 33004 | ||
| xai_download_url: "https://github.com/xai-foundation/sentry/releases/latest/download/sentry-node-cli-linux.zip" | ||
|
|
There was a problem hiding this comment.
depin.core.installer is expecting the variable xai_programs which is a list of all binaries that're downloaded and then installed
xai_programs
- [name of binary]There was a problem hiding this comment.
To configure this part correctly - need to receive license key and test wallet. Only after that XAI can be correctly configured, tested and then automated.
There was a problem hiding this comment.
can't do this without test license keys and wallet
There was a problem hiding this comment.
can't do this without test license keys and wallet
There was a problem hiding this comment.
The use of this file was removed on a recent breaking_change that was pushed. The hychain_private_key is being pulled and set via Pulumi ESC.
…vice' into 09-10-feat_sparkles_adds_xai_service # Conflicts: # depin/services/roles/xai/defaults/main.yml
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -0,0 +1,2 @@ | |||
| --- | |||
| xai_metrics_port: 33004 | |||
There was a problem hiding this comment.
The xai_metrics_port value of 33004 conflicts with the storagechain port assignment in defaults/main.yml. To maintain consistency with the metrics configuration, this value should be 33005.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| --- | ||
| # Run the XAI Sentry Node CLI |
There was a problem hiding this comment.
The start.yml task appears to be missing the implementation to start the XAI service. The xai_start_command variable is defined in defaults/main.yml but not utilized here. Consider adding a task to execute this command, likely using the ansible.builtin.command module.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| --- | ||
| # Stop XAI Sentry Node service |
There was a problem hiding this comment.
The stop.yml task appears to be missing the implementation to stop the XAI service. Consider adding a task that uses the xai_stop_command variable defined in defaults/main.yml to properly terminate the service.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
the same - without license keys impossible to write and check start/stop
| xai_programs: | ||
| - name: sentry-node-cli-linux | ||
| url: "{{ xai_download_url }}" | ||
| checksum: "" |
There was a problem hiding this comment.
The checksum field is empty, which bypasses an important security check. Adding a SHA256 checksum for the XAI Sentry Node binary would protect against supply chain attacks and ensure binary integrity during downloads. Consider obtaining the official checksum from the XAI Foundation release page.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Done |
anthonyra
force-pushed
the
main
branch
2 times, most recently
from
0f56e67 to
8f5689c
Compare
4 participants
No description provided.