fix: allowed to strip the workflow manifest from hangfire serialization

Author: pksorensen

src/WorkflowEngine.Core/IWorkflow.cs

@@ -6,7 +6,11 @@ public interface IWorkflow // Documentet
     {
         public Guid Id { get;  }
         public string Version { get;  }
-        public WorkflowManifest Manifest { get; }
+        public WorkflowManifest Manifest { get; set; }
+
+
+      
+
 
     }
 

src/WorkflowEngine.Core/TriggerContext.cs

@@ -18,7 +18,7 @@ public string ToString(string format, IFormatProvider formatProvider)
                 return $"{Workflow?.GetType().Name} workflow={Workflow?.Id} version={Workflow?.Version} trigger={Trigger?.Key}";
             }
 
-            if (format == "Id")
+            if (format == "Id" && RunId != Guid.Empty)
                 return RunId.ToString();
 
             return string.Empty;

src/WorkflowEngine.Core/Workflow.cs

@@ -8,7 +8,8 @@ public class Workflow : IWorkflow, IFormattable
         public Guid Id { get; set; }
         public string Version { get; set; }
         public WorkflowManifest Manifest { get; set; }
-
+        
+      
         public string ToString(string format, IFormatProvider formatProvider)
         {
             if (format == "Id")

src/WorkflowEngine.Hangfire/DependencyInjectionExtensions.cs

@@ -29,6 +29,7 @@ public static IServiceCollection AddWorkflowEngine<TOutputsRepository>(this ISer
 
             services.AddHostedService<WorkflowStarterBackgroundJob>();
 
+            services.AddTransient<IWorkflowAccessor, DefaultWorkflowAccessor>();
             return services;
         }
 

src/WorkflowEngine.Hangfire/HangfireWorkflowExecutor.cs

@@ -1,6 +1,9 @@
 using Hangfire;
 using Hangfire.Server;
 using System;
+using System.Collections;
+using System.Collections.Generic;
+using System.Linq;
 using System.Threading.Tasks;
 using WorkflowEngine.Core;
 using WorkflowEngine.Core.Actions;
@@ -9,18 +12,37 @@
 
 namespace WorkflowEngine
 {
-   
+
+    public interface IWorkflowAccessor
+    {
+        ValueTask<WorkflowManifest> GetWorkflowManifestAsync(IWorkflow workflow);
+    }
+    public class DefaultWorkflowAccessor : IWorkflowAccessor
+    {
+        private readonly IEnumerable<IWorkflow> workflows;
+
+        public DefaultWorkflowAccessor(IEnumerable<IWorkflow> workflows)
+        {
+            this.workflows = workflows ?? throw new ArgumentNullException(nameof(workflows));
+        }
+        public ValueTask<WorkflowManifest> GetWorkflowManifestAsync(IWorkflow workflow)
+        {
+            return new ValueTask<WorkflowManifest>(workflows.FirstOrDefault(x=>x.Id == workflow.Id && workflow.Version == x.Version).Manifest);
+        }
+    }
     public class HangfireWorkflowExecutor : IHangfireWorkflowExecutor, IHangfireActionExecutor
     {
+        private readonly IWorkflowAccessor workflowAccessor;
         private readonly IBackgroundJobClient backgroundJobClient;
         private readonly IRunContextAccessor runContextAccessor;
         private readonly IWorkflowExecutor executor;
         private readonly IActionExecutor actionExecutor;
         private readonly IOutputsRepository outputRepository;
         private readonly IArrayContext arrayContext;
 
-        public HangfireWorkflowExecutor(IBackgroundJobClient backgroundJobClient, IArrayContext arrayContext, IRunContextAccessor runContextAccessor, IWorkflowExecutor executor, IActionExecutor actionExecutor, IOutputsRepository actionResultRepository)
+        public HangfireWorkflowExecutor(IWorkflowAccessor workflowAccessor, IBackgroundJobClient backgroundJobClient, IArrayContext arrayContext, IRunContextAccessor runContextAccessor, IWorkflowExecutor executor, IActionExecutor actionExecutor, IOutputsRepository actionResultRepository)
         {
+            this.workflowAccessor = workflowAccessor ?? throw new ArgumentNullException(nameof(workflowAccessor));
             this.backgroundJobClient=backgroundJobClient??throw new ArgumentNullException(nameof(backgroundJobClient));
             this.arrayContext=arrayContext??throw new ArgumentNullException(nameof(arrayContext));
             this.runContextAccessor=runContextAccessor;
@@ -38,10 +60,15 @@ public HangfireWorkflowExecutor(IBackgroundJobClient backgroundJobClient, IArray
 
         public async ValueTask<object> ExecuteAsync(IRunContext run, IWorkflow workflow, IAction action, PerformContext context)
         {
+            //TODO - avoid sending all workflow over hangfire, so we should lookup the manifest here if not set on workflow form its ID.
+            workflow.Manifest ??= await workflowAccessor.GetWorkflowManifestAsync(workflow);
+
+
             runContextAccessor.RunContext = run;
             arrayContext.JobId=context.BackgroundJob.Id;
 
 
+           
             var result = await actionExecutor.ExecuteAsync(run, workflow, action);
 
 
@@ -76,14 +103,19 @@ public async ValueTask<object> ExecuteAsync(IRunContext run, IWorkflow workflow,
         /// <returns></returns>
         public async ValueTask<object> TriggerAsync(ITriggerContext context)
         {
-           
+            //TODO - avoid sending all workflow over hangfire,
+            context.Workflow.Manifest ??= await workflowAccessor.GetWorkflowManifestAsync(context.Workflow);
+
             context.RunId = context.RunId == Guid.Empty? Guid.NewGuid() : context.RunId;
 
             runContextAccessor.RunContext = context;
             var action = await executor.Trigger(context);
 
             if (action != null)
             {
+                //TODO - avoid sending all workflow over hangfire, so we should wipe the workflow.manifest before scheduling and restore it after.
+                context.Workflow.Manifest = null;
+                
 
                 var a = backgroundJobClient.Enqueue<IHangfireActionExecutor>(
                             (executor) => executor.ExecuteAsync(context, context.Workflow, action,null));

src/WorkflowEngine.Hangfire/ScheduledWorkflowTrigger.cs

@@ -40,10 +40,22 @@ public Task<string> Trigger(string externalid, bool create, DateTimeOffset time,
             if (create)
             {
                 var workflow = new TWorkflow();
-                workflow.Manifest.Triggers.First().Value.Inputs = inputs;
+                var trigger = new Trigger
+                {
+                    Inputs = inputs,
+                    ScheduledTime = DateTimeOffset.UtcNow,
+                    Type = workflow.Manifest.Triggers.FirstOrDefault().Value.Type,
+                    Key = workflow.Manifest.Triggers.FirstOrDefault().Key
+                };
+                
+                 
+
+                //TODO - avoid sending all workflow over hangfire,
+                workflow.Manifest = null;
 
                 var job = _backgroundJobClient.Schedule<IHangfireWorkflowExecutor>((executor) => executor.TriggerAsync(
-                    new TriggerContext { Workflow = workflow, }), time);
+                    new TriggerContext { Workflow = workflow, Trigger = trigger ,
+                    }), time);
 
                 _logger.LogInformation("Created scheduled workflow job {JobID}", job);