From efdbb49e2c9cce0046642a58dad84a79a476313c Mon Sep 17 00:00:00 2001 From: root Date: Mon, 3 Nov 2025 18:41:58 +0000 Subject: [PATCH 1/4] update release --- .github/workflows/create-tag-release.yaml | 69 ----------------------- .github/workflows/license-checker.yaml | 2 - .github/workflows/release-image.yaml | 59 ------------------- .github/workflows/release.yaml | 32 +++++++++++ 4 files changed, 32 insertions(+), 130 deletions(-) delete mode 100644 .github/workflows/create-tag-release.yaml delete mode 100644 .github/workflows/release-image.yaml create mode 100644 .github/workflows/release.yaml diff --git a/.github/workflows/create-tag-release.yaml b/.github/workflows/create-tag-release.yaml deleted file mode 100644 index 309431b6..00000000 --- a/.github/workflows/create-tag-release.yaml +++ /dev/null @@ -1,69 +0,0 @@ -name: Create Tag and Release -# Invocable as a reusable workflow -# Can be manually triggered -on: # yamllint disable-line rule:truthy - workflow_call: - workflow_dispatch: - inputs: - option: - description: 'Select version to release' - required: true - type: choice - default: 'minor' - options: - - major - - minor - - patch - - n-1/n-2 patch (Provide input in the below box) - version: - description: "Patch version to release. example: 2.1.x (Use this only if n-1/n-2 patch is selected)" - required: false - type: string - repository_dispatch: - types: [auto-release-workflow] - -jobs: - process-inputs: - name: Process Inputs - runs-on: ubuntu-latest - outputs: - processedVersion: ${{ steps.set-version.outputs.versionEnv }} - steps: - - name: Process input - id: set-version - shell: bash - run: | - echo "Triggered by: ${{ github.event_name }}" - if [[ "${{ github.event_name }}" == "repository_dispatch" ]]; then - echo "versionEnv=minor" >> $GITHUB_OUTPUT - exit 0 - fi - if [[ "${{ github.event.inputs.version }}" != "" && "${{ github.event.inputs.option }}" == "n-1/n-2 patch (Provide input in the below box)" ]]; then - echo "versionEnv=${{ github.event.inputs.version }}" >> $GITHUB_OUTPUT - exit 0 - fi - if [[ "${{ github.event.inputs.option }}" != "n-1/n-2 patch (Provide input in the below box)" ]]; then - echo "versionEnv=${{ github.event.inputs.option }}" >> $GITHUB_OUTPUT - exit 0 - fi - echo "versionEnv=minor" >> $GITHUB_OUTPUT - - csm-release: - needs: process-inputs - uses: dell/common-github-actions/.github/workflows/create-tag-release.yaml@main - name: Create Tag and Release - with: - version: ${{ needs.process-inputs.outputs.processedVersion }} - images: 'csi-vxflexos' - secrets: inherit - - next-steps: - name: 📌 Next Steps for Release Process - runs-on: ubuntu-latest - needs: csm-release - steps: - - name: Share next steps with user - run: | - echo "✅ Tag and release completed." - echo "➡️ Please manually trigger the Jenkins image build job: CSM-Images-Build-Nightly." - echo "🚀 Once the Jenkins image build job is successful, trigger the Release Image workflow from GitHub Actions." diff --git a/.github/workflows/license-checker.yaml b/.github/workflows/license-checker.yaml index ec134b10..02e1cc5d 100644 --- a/.github/workflows/license-checker.yaml +++ b/.github/workflows/license-checker.yaml @@ -1,8 +1,6 @@ name: Weekly License Header Check on: - schedule: - - cron: '0 0 * * 1' # Runs every Monday at 00:00 UTC workflow_dispatch: jobs: license-check: diff --git a/.github/workflows/release-image.yaml b/.github/workflows/release-image.yaml deleted file mode 100644 index a0c8a175..00000000 --- a/.github/workflows/release-image.yaml +++ /dev/null @@ -1,59 +0,0 @@ -name: Release CSI-Powerflex Image -# Invocable as a reusable workflow -# Can be manually triggered -on: # yamllint disable-line rule:truthy - workflow_call: - workflow_dispatch: - inputs: - option: - description: 'Select version to release' - required: true - type: choice - default: 'minor' - options: - - major - - minor - - patch - - n-1/n-2 patch (Provide input in the below box) - version: - description: "Patch version to release. example: 2.1.x (Use this only if n-1/n-2 patch is selected)" - required: false - type: string - repository_dispatch: - types: [auto-release-workflow] -jobs: - process-inputs: - name: Process Inputs - runs-on: ubuntu-latest - outputs: - processedVersion: ${{ steps.set-version.outputs.versionEnv }} - steps: - - name: Process input - id: set-version - shell: bash - run: | - echo "Triggered by: ${{ github.event_name }}" - if [[ "${{ github.event_name }}" == "repository_dispatch" ]]; then - echo "versionEnv=minor" >> $GITHUB_OUTPUT - exit 0 - fi - if [[ "${{ github.event.inputs.version }}" != "" && "${{ github.event.inputs.option }}" == "n-1/n-2 patch (Provide input in the below box)" ]]; then - # if both version and option are provided, then version takes precedence i.e. patch release for n-1/n-2 - echo "versionEnv=${{ github.event.inputs.version }}" >> $GITHUB_OUTPUT - exit 0 - fi - if [[ "${{ github.event.inputs.option }}" != "n-1/n-2 patch (Provide input in the below box)" ]]; then - # if only option is provided, then option takes precedence i.e. minor, major or patch release - echo "versionEnv=${{ github.event.inputs.option }}" >> $GITHUB_OUTPUT - exit 0 - fi - # if neither option nor version is provided, then minor release is taken by default (Auto-release) - echo "versionEnv=minor" >> $GITHUB_OUTPUT - csm-release: - needs: [process-inputs] - uses: dell/common-github-actions/.github/workflows/release-image.yaml@main - name: Release Image - with: - version: ${{ needs.process-inputs.outputs.processedVersion }} - images: 'csi-vxflexos' - secrets: inherit diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml new file mode 100644 index 00000000..d1ec039c --- /dev/null +++ b/.github/workflows/release.yaml @@ -0,0 +1,32 @@ +name: Create Tag and Release +# Invocable as a reusable workflow +# Can be manually triggered +on: # yamllint disable-line rule:truthy + workflow_call: + workflow_dispatch: + inputs: + option: + description: "Select type of release. If first release, use major and it will release v1.0.0." + required: true + type: choice + default: "minor" + options: + - major + - minor + - patch + - version + version: + description: "Specific semver version to release. Only used when 'version' is the selected option. Example: v2.1.x." + required: false + type: string + repository_dispatch: + types: [auto-release-workflow] + +jobs: + csm-release: + name: Create Tag and Release + uses: dell/common-github-actions/.github/workflows/create-tag-release.yaml@main + with: + option: ${{ inputs.option || "minor" }} + version: ${{ inputs.version || "" }} + secrets: inherit From 8e2ed4d6e9e01c3ca46caf14b64a9ab93053cfe0 Mon Sep 17 00:00:00 2001 From: root Date: Mon, 3 Nov 2025 19:07:29 +0000 Subject: [PATCH 2/4] revert name change --- .github/workflows/{release.yaml => create-tag-release.yaml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{release.yaml => create-tag-release.yaml} (100%) diff --git a/.github/workflows/release.yaml b/.github/workflows/create-tag-release.yaml similarity index 100% rename from .github/workflows/release.yaml rename to .github/workflows/create-tag-release.yaml From f3d3e71d2ba963c9769a95361de5b00c6bfbcde1 Mon Sep 17 00:00:00 2001 From: root Date: Mon, 3 Nov 2025 19:41:43 +0000 Subject: [PATCH 3/4] fix quotation --- .github/workflows/create-tag-release.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/create-tag-release.yaml b/.github/workflows/create-tag-release.yaml index d1ec039c..e59b269a 100644 --- a/.github/workflows/create-tag-release.yaml +++ b/.github/workflows/create-tag-release.yaml @@ -27,6 +27,6 @@ jobs: name: Create Tag and Release uses: dell/common-github-actions/.github/workflows/create-tag-release.yaml@main with: - option: ${{ inputs.option || "minor" }} - version: ${{ inputs.version || "" }} + option: ${{ inputs.option || 'minor' }} + version: ${{ inputs.version || '' }} secrets: inherit From 6cd5ecc5d5de277fd8dbb32a18e554484c4bfe60 Mon Sep 17 00:00:00 2001 From: root Date: Tue, 4 Nov 2025 14:26:54 +0000 Subject: [PATCH 4/4] remove deprecate build tags to pass govet --- plugin.go | 1 - test/e2e/e2e_test.go | 1 - test/integration/integration_test.go | 1 - test/integration/step_defs_test.go | 1 - 4 files changed, 4 deletions(-) diff --git a/plugin.go b/plugin.go index e0ae244a..46c3cbe9 100644 --- a/plugin.go +++ b/plugin.go @@ -11,7 +11,6 @@ // limitations under the License. // //go:build linux && plugin -// +build linux,plugin //go:generate go generate ./core diff --git a/test/e2e/e2e_test.go b/test/e2e/e2e_test.go index ee266d42..147f7eda 100644 --- a/test/e2e/e2e_test.go +++ b/test/e2e/e2e_test.go @@ -12,7 +12,6 @@ // //go:build integration -// +build integration package e2e diff --git a/test/integration/integration_test.go b/test/integration/integration_test.go index adc76992..30dc0d6c 100644 --- a/test/integration/integration_test.go +++ b/test/integration/integration_test.go @@ -12,7 +12,6 @@ // //go:build integration -// +build integration package integration_test diff --git a/test/integration/step_defs_test.go b/test/integration/step_defs_test.go index a488f783..336da71e 100644 --- a/test/integration/step_defs_test.go +++ b/test/integration/step_defs_test.go @@ -12,7 +12,6 @@ // //go:build integration -// +build integration package integration_test