Skip to content

practice-html-and-css-basics#211

Open
bartoszdudziak-dev wants to merge 5 commits into
devmentor-pl:masterfrom
bartoszdudziak-dev:master
Open

practice-html-and-css-basics#211
bartoszdudziak-dev wants to merge 5 commits into
devmentor-pl:masterfrom
bartoszdudziak-dev:master

Conversation

@bartoszdudziak-dev

Copy link
Copy Markdown

No description provided.

@devmentor-pl devmentor-pl left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BArtku,

Świetnie sobie poradziłeś z zadaniami! 👍
Zostawiłem jedną uwagę do zadania 03.

Comment thread 01/index.html
<section id="comments">
<h2>Comments</h2>
<form>
<textarea id="newComment" cols="40" rows="10">

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warto pole formularza osadzić w jakiś element blokowy np. div lub p

Comment thread 02/styles/index.css
height: 230px;
} No newline at end of file
height: 230px;
}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/styles/index.css
}

/* Float Method */
.parent--float > .child {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warto dodać do .parent--float tzw. "clearfix".
Bez tego rodzic nie zajmuje całej przestrzeni i jeśli dodamy do niego tło to będzie problem:

Screenshot 2024-12-17 at 07 03 46

Comment thread 04/index.html
</nav>
</header>
</body>
</html>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 04/styles/index.css

.nav__item--dropdown .nav__submenu > .nav__item:hover .arrow-right {
border-left-color: var(--primary-color);
}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 05/index.html
<div class="section-3 container"><div class="info content"></div></div>
</footer>
</body>
</html>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 05/styles/index.css
.info {
height: 50px;
width: 200px;
}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants