Skip to content

practice-html-and-css-basics from Neil #214

Open
Neil-Gorski wants to merge 11 commits into
devmentor-pl:masterfrom
Neil-Gorski:master
Open

practice-html-and-css-basics from Neil #214
Neil-Gorski wants to merge 11 commits into
devmentor-pl:masterfrom
Neil-Gorski:master

Conversation

@Neil-Gorski

Copy link
Copy Markdown

No description provided.

@devmentor-pl devmentor-pl left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nail,

Zadania są ok 👍
Zostawiłem parę drobnych uwag w komentarzach :)

Comment thread 01/index.html
<article>
<h2><a href="/travel/germany">Visit Oktoberfest in Germany</a></h2>
<img
src=".\1280px-Haupteingang_Oktoberfest_2012.jpg"

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W HTML ukośniki robimy w drugą stronę tj. ./1280px-...

Comment thread 01/index.html
<hr />
<div class="comments">
<div class="comment">
<author>Flynn Wilson</author><br />

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Takiego znacznika nie ma, można użyć atrybutu rel="author" np. <a href="https://example.com/o-autorze" rel="author">Jan Kowalski</a>

Comment thread 02/styles/index.css
(0, 2, 2)
*/
?? {
.ac-container input:active ~ article {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/index.html
</div><!--
--><div class="child child--last">
Lorem ipsum dolor sit amet consectetur adipisicing elit. Delectus, iure?
</div>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/styles/style.css
}
.child--middle {
margin: 0 10px ;
} No newline at end of file

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 04/index.html
</ul>
</nav>
</body>
</html>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 04/styles/style.css
Comment on lines +29 to +30
.navbar > ul > li:nth-child(3),
.navbar > ul > li:nth-child(4) {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Łatwiej jest, przy bardziej rozbudowanych przypadkach używać odpowiednich klas.
Co jeśli pojawi się kolejny rozwijany element? Wtedy będzie trzeba modyfikować nie tylko HTML, ale też CSS

Comment thread 04/styles/style.css
Comment on lines +73 to +80
.navbar__dropdown > ul > li:nth-child(2)::after {
position: absolute;
display: inline-block;
content: ">";
right: 8px;
visibility: hidden;
}
.navbar__dropdown > ul > li:nth-child(2):hover::after {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podobnie tutaj. Tworzenie rozbudowanych selektorów powoduje, że całość rozwiązania staje się bardziej złożone.
Lepiej użyć klasy. zamiast .navbar__dropdown > ul > li:nth-child(2)

Comment thread 05/index.html
<div class="container footer__container"><div></div></div>
</footer>
</body>
</html>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 05/styles/style.css
}
.footer__container div {
width: 15%;
} No newline at end of file

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants