Zadania zrobione#218
Conversation
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Michale,
Zadanka są ok! 👍
Zostawiłem w paru komentarzach drobne uwagi :)
| </footer> | ||
| </div> | ||
| </body> | ||
|
|
| } | ||
|
|
||
| .ac-container input:checked ~ article.ac-large { | ||
| .ac-container input:checked~article.ac-large { |
| width: 40%; | ||
| margin-right: 0; | ||
| font-style: italic; | ||
| } No newline at end of file |
| href="#" | ||
| >Item 1</a></li> | ||
| <li class="dropdown__item">Item 2 <div class="arrow__right"> > </div> | ||
| <ul class="nav__dropdown dropdown--right"> |
There was a problem hiding this comment.
Skoro mamy Modyfikator tj. dropdown--right to powinien również pojawić sie Blok tj. dropdown czyli razem będzie tak: nav__dropdown dropdown dropdown--right. Więcej o BEM możesz przeczytać tutaj:
https://devmentor.pl/b/metodologia-bem-w-css-i-sass
| >Item 1</a></li> | ||
| <li class="dropdown__item">Item 2 <div class="arrow__right"> > </div> | ||
| <ul class="nav__dropdown dropdown--right"> | ||
| <li class="dropdown__item-sub"><a |
There was a problem hiding this comment.
Te drugie zagnieżdżenie powinno być w tej samej płaszczyźnie - wystarczy dodać dla ul -> top: 0, a dla .dropdown__item -> position: relative
| <div class="section__container container"> | ||
| <div class="section__item-middle cell"></div> | ||
| <div class="section__item-middle cell"></div> | ||
| <div class="section__item-right cell"></div> |
There was a problem hiding this comment.
Dlaczego tutaj też nie dać section__item-middle zamiast section__item-right?
|
|
||
| min-height: 50px; | ||
| outline-color: orange; | ||
| } No newline at end of file |
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Michale,
O to chodziło 👍 z jeszcze jedną, małą uwagą :)
| >Item 1</a></li> | ||
| <li class="dropdown__item">Item 2 <div class="arrow__right"> > </div> | ||
| <ul class="nav__dropdown dropdown--right"> | ||
| <ul class="nav__dropdown dropdown dropdown--right"> |
| } | ||
|
|
||
| .dropdown__item { | ||
| position: relative; |
| display: none; | ||
| position: absolute; | ||
| left: 240px; | ||
| top: 0; |
| <div class="section__item-middle cell"></div> | ||
| <div class="section__item-middle cell"></div> | ||
| <div class="section__item-right cell"></div> | ||
| <div class="section__item--middle cell"></div> |
There was a problem hiding this comment.
Skoro zmieniłeś nazwę i tutaj masz Modyfikator, to brakuje nazwy Elementu tj. section__item.
2 participants
No description provided.