Skip to content

End of basic HTML and CSS practice#222

Open
AlexKry96 wants to merge 13 commits into
devmentor-pl:masterfrom
AlexKry96:master
Open

End of basic HTML and CSS practice#222
AlexKry96 wants to merge 13 commits into
devmentor-pl:masterfrom
AlexKry96:master

Conversation

@AlexKry96

Copy link
Copy Markdown

No description provided.

@devmentor-pl devmentor-pl left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olek,

Zadania wyszły bardzo dobrze! 👍
Zostawiłem parę drobnych uwag.

Comment thread 01/index.html
Comment on lines +97 to +103
<label for="author">Autor:</label><br>
<input
type="text"
id="author"
name="author"
required
><br><br>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dobrze pola formularza umieścić w elemencie blokowym tj. div lub p, wtedy odstępy zrobią się automatycznie.
br używamy jedynie do "łamania" tekstu, a nie robienia odstępów.

Comment thread 01/index.html
Comment on lines +118 to +119
<div>
<p>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Można też użyć ul > li bo mamy "listę" komentarzy.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Na GH warto wrzucać pliki, które są niezbędne lub z których korzystamy. Myślę, że ten akrat nie jest potrzebny :)

Comment thread 04/index.html
</nav>
</body>

</html> No newline at end of file

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 04/style.css
right: 5px;
top:10px;
/* transform: rotate(90deg); */
} No newline at end of file

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 05/index.html
</footer>

</body>
</html> No newline at end of file

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/style.css
@@ -0,0 +1,92 @@

@font-face {
font-family: 'SourceSansPro-Italic';

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Można też użyć tej samej nazwy we wszyskich przypadkach np. SourceSansPro, wtedy przeyglądarka na podstawie definicji font-weight oraz font-style będzie dobierać odpowiedni plik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants