practice-html-and-css-rwd done#167
Open
satoshi300 wants to merge 11 commits into
Open
Conversation
devmentor-pl
approved these changes
Apr 26, 2025
devmentor-pl
left a comment
devmentor-pl
left a comment
Owner
There was a problem hiding this comment.
Michale,
Zadania wyglądają ok 👍
Parę drobnych uwag zostawiłem, ale nie widzę jakiś większych odstępów od wymagań 👍
| "a-mid a-bottom"; | ||
| max-width: 1200px; | ||
| margin: 0 auto; | ||
| } No newline at end of file |
| display: block; | ||
| content: ''; | ||
| height: 0; | ||
| shape-outside: polygon(0 1%, 0% 100%, 100% 0); |
Owner
There was a problem hiding this comment.
Raczej dałbym 0 zamiast 1% - chciałbym zacząć od samego początku
| } | ||
|
|
||
| .c { | ||
| grid-area: a-bottom; |
Owner
There was a problem hiding this comment.
Brakuje jeszcze wysokości dla każdego elementu (50vh)
| > | ||
| </picture> | ||
| </header> | ||
| <side class="v"><iframe width="560" height="315" src="https://www.youtube.com/embed/RhUuMl3R1PE?si=lY_1I9X4lzqCIM0e" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe></side> |
| ; | ||
| max-width: 1400px; | ||
| margin: 0 auto; | ||
| } |
| class="nav__link" | ||
| href="#" | ||
| >strony internetowe</a></li> | ||
| <li class="dropdown__item nav__item"> pozycjonowanie<div class="arrow__right"> > </div> |
Owner
There was a problem hiding this comment.
Zamiast tworzyć element div.arrow_right można wykorzystać pseudo-element ::after
| </footer> | ||
| </body> | ||
|
|
||
| </html> No newline at end of file |
| .cell { | ||
| min-height: 50px; | ||
| outline-color: orange; | ||
| } No newline at end of file |
devmentor-pl
approved these changes
May 5, 2025
devmentor-pl
left a comment
devmentor-pl
left a comment
Owner
There was a problem hiding this comment.
Michale,
Super, o to chodziło! 👍
| content: ''; | ||
| height: 0; | ||
| shape-outside: polygon(0 1%, 0% 100%, 100% 0); | ||
| shape-outside: polygon(0 0%, 0% 100%, 100% 0); |
Owner
There was a problem hiding this comment.
Jak wpisujemy 0 to nie musimy dawać jednostki bo 0 to zero - obojętnie czy px czy %
| >start</a> | ||
| </li> | ||
| <li class="nav__item"> oferta<div class="arrow__down"> <span> > </span> </div> | ||
| <li class="nav__item arrow"> oferta |
| position: relative; | ||
| left: 35px; | ||
| padding-right: 10px; | ||
| transform: rotate(90deg); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zadanie 4 nie jest w 100% zrobione tak jak bylo w poleceniu