Skip to content

Review preserved Fleet/session changes from fix/chat-scroll-follow-tail #131

Description

@devswha

Preserved work

fix/chat-scroll-follow-tail has no associated PR. Its tip is 103e70bb49aebd422107f0c0183af55768807ce4 and its history diverges from audited main (076fd4f003b66c1f68d16e45006bba8ac827103d) by 13 branch commits and 65 main commits. The branch remains preserved; it has not been merged or deleted during repository cleanup.

The branch name understates its scope: it contains Fleet navigation, catalog, discovery, watcher, and host-scoping changes as well as scroll behavior. These are historical proposals, not a verified list of defects in current main.

Review by behavior

  • Confirm the follow-tail work in 2084ad0 is covered by merged PR fix(chat, sessions): autoscroll follow-tail, missing-cwd creation, fail-closed resume guard #99, which explicitly adopted and extended that design.
  • Review remote tmux rows, mapped transcripts, terminal-to-transcript navigation, idle transcript retention, and remote controls (53cf0dc, 5fa379b, c5b2636, b2e3fdc, e957f21).
  • Review transient GJC probe filtering and unchanged heartbeat handling (1d2fbf8, 06875a1).
  • Review catalog/watcher bounds, remote project names, and OpenCode database watching against the newer implementations on main (b02502c, 031b2c4, da740ce).
  • Review long-lived peer read accounting against the request-ledger changes already shipped on main (7c9cf15).
  • Review the remote-session guards for local-only APIs against the current host-qualified routing contract (103e70b).

For each group, record whether current main already covers it, it is intentionally superseded, or a focused PR is needed. Keep the branch until every group has a recorded disposition or another durable recovery reference.

Integration requirements

Do not merge the historical branch as one integration batch. Base any retained changes on then-current main, preserve exact tmux/provider/host identity checks, and update normative contracts first if behavior would widen their scope. Run focused behavior tests and all required checks against latest main before each squash merge. Historical tests or commit presence alone do not prove compatibility with current main.

Completed review

All thirteen preserved commits and all six groups have a recorded disposition in the review. Retained corrections were merged through #133, #134, #135, and #136 after all required checks passed against each then-current main. The final Node 22 dependency-download HTTP 403 was resolved by rerunning that job on the same head.

Already-shipped changes and intentionally unadopted proposals are identified separately in the review. The historical branch remains preserved.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    deferredPreserved for future review; not scheduled for implementation.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions