From 69c224b713adde6e269aa7c4d2c35ecc1962f20f Mon Sep 17 00:00:00 2001 From: Davide Angelocola Date: Tue, 23 Jun 2026 08:12:26 +0200 Subject: [PATCH] fix(sonar): suppress S1172 on AbstractMaterializedArray.materialize The arena parameter is contractual: this base method implements Array#materialize(SegmentAllocator) for the leaf Materialized* classes, which implement the sealed Array interface directly. Sonar cannot see the override because the base class is not itself declared to implement Array, so it flagged arena as an unused parameter. The parameter must stay to satisfy the interface; suppress with an explanatory reason instead. Co-Authored-By: Claude Opus 4.8 --- .../dfa1/vortex/reader/array/AbstractMaterializedArray.java | 1 + 1 file changed, 1 insertion(+) diff --git a/reader/src/main/java/io/github/dfa1/vortex/reader/array/AbstractMaterializedArray.java b/reader/src/main/java/io/github/dfa1/vortex/reader/array/AbstractMaterializedArray.java index 9420787c..8beb6861 100644 --- a/reader/src/main/java/io/github/dfa1/vortex/reader/array/AbstractMaterializedArray.java +++ b/reader/src/main/java/io/github/dfa1/vortex/reader/array/AbstractMaterializedArray.java @@ -51,6 +51,7 @@ public final long length() { /// /// @param arena unused; the existing buffer is returned as-is /// @return the backing segment + @SuppressWarnings("java:S1172") // arena is contractual: this implements Array#materialize(SegmentAllocator) for the leaf classes; unused only because the buffer is already materialized. public final MemorySegment materialize(SegmentAllocator arena) { return buffer; }