Text in main window unreadable on dark theme

[frank-weinberg]

Describe the bug
On a system with dark theme the text in the main window is black on dark, making it unreadable.

To Reproduce

• Configure system to use dark theme.
• Start jamstats

Expected behavior
Either both background and text color are hardcoded or both are taken from the system theme

Screenshots

Additional context
Observed on Linux/KDE

[dhmay]

Just to make sure: this is only an issue for the window you screenshotted, which contains the jamstats info messages, right? Not with the browser?
That window is handled by a GUI package called Gooey. I think I can change the theme in that window, but I'm not sure how to find out that I need to, i.e., find out (in a platform-independent way) whether someone's system is in dark mode. I could add another command line argument that controls the Gooey window theme. Would that do it?

[frank-weinberg]

Yes, it's only this window. (The setup window has white text in the input fields.)
And needing a command line parameter would be imperfect but a clear improvement over the current state.

[dhmay]

Oh, whoops, this has nothing to do with Gooey, it's about how the app is packaged up. That's different for Windows than for Mac. Are you Windows or Mac?

[frank-weinberg]

Neither. Linux w/ KDE.

[dhmay]

Then I'm not understanding how you're running JamStats! I'm aware of three ways to run JamStats:

• the .exe Windows binary
• the Mac app
• the script bin/jamstats, from the source distribution

If you're on Linux, I would expect you'd have to be running from source. If you're running from source, can't you just

cd <jamstats root dir>
bin/jamstats

Then the output will go to your terminal, not to any pesky window. How are you managing to create a pesky window? WINE and the Windows binary?

[frank-weinberg]

'uv tool install jamstats'
'jamstats'

I don't think it uses wine as I don't think that's integrated into the python ecosystem here.

(I used to install it via pipx but that's been removed by my distro and uv has been pointed to as replacement.)

And I see the first line in your requirements.txt is wxpython - that's available on Linux.

[dhmay]

Oh! That's funny. It turns out I get exactly the same behavior on my Mac, when I run from source with no arguments. I've never actually run the jamstats script with no arguments, before!

I built that GUI interface (which captures the arguments and then makes a window to capture all the output) to support people running JamStats from the executables, and it seems to work fine for the executables. But if you run JamStats with no args from the command line, it invokes that GUI, and, indeed, in dark mode, it's unreadable.

So, the thing you can do immediately is run jamstats the way I run it: instead of running jamstats, run e.g., jamstats ~/derby_games/my_derby_game.json. Or if you're connecting to a scoreboard, specify those args -- jamstats --help will help you with the args. Then the output will go to your terminal and will be totally readable.

I was hoping that another option would be to start a terminal with a white background and run jamstats with no args from there. But that doesn't seem to work, for me: the window it creates for the output gets a dark background anyway.

I'll keep poking at that, but I think there's a chance I won't be able to solve it. Does running jamstats with arguments specified on the commandline work for you?

[frank-weinberg]

jamstats --scoreboardserver localhost:8000 works with (readable) output on the console. So my issue is addressed, thank you for your help.
(I'll leave the ticket open since you indicated you may still do some poking around.)