Skip to content

Fix Frappe v15 breadcrumbs update patch#10

Merged
bhushan-barbuddhe merged 1 commit into
dhwani-ris:developmentfrom
vaishalisahni:development
Jan 15, 2026
Merged

Fix Frappe v15 breadcrumbs update patch#10
bhushan-barbuddhe merged 1 commit into
dhwani-ris:developmentfrom
vaishalisahni:development

Conversation

@vaishalisahni

Copy link
Copy Markdown

Description:
This PR patches frappe.breadcrumbs.update to handle a Frappe v15 behavior where this.all is not populated for Query Reports. Without this patch, opening query reports results in a TypeError when trying to read properties of undefined (e.g., HR, Projects).

Changes included:

Added a safe patch that preserves the original frappe.breadcrumbs.update for cases where this.all[page] is undefined.

Ensures breadcrumbs are properly displayed for Forms, Lists, and Dashboard views.

Compatible with Frappe v15 and does not affect other apps or previous behavior.

Files modified:

public/js/sidebar/breadcrumb_override_patch.js

Issue fixed:

Prevents Uncaught TypeError: Cannot read properties of undefined (reading 'HR') in Query Reports.

Testing:

Verified in Frappe v15 with Query Reports and standard List/Form views.

Breadcrumbs render correctly and no errors in console.

@codecov

codecov Bot commented Jan 14, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@bhushan-barbuddhe

Copy link
Copy Markdown
Collaborator

@vaishalisahni CI workflows are failing due to pre-commit & semantic commit checks.

Please run pre-commit locally, fix the reported issues, and ensure commits follow semantic (conventional) commit

@vaishalisahni

Copy link
Copy Markdown
Author

@bhushan-barbuddhe Fixed the pre-commit issues and amended the commit message to follow semantic conventions. CI should pass now.

@bhushan-barbuddhe bhushan-barbuddhe merged commit e35319b into dhwani-ris:development Jan 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants