Fix Frappe v15 breadcrumbs update patch#10
Merged
bhushan-barbuddhe merged 1 commit intoJan 15, 2026
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
bhushan-barbuddhe
approved these changes
Jan 14, 2026
Collaborator
|
@vaishalisahni CI workflows are failing due to pre-commit & semantic commit checks. Please run pre-commit locally, fix the reported issues, and ensure commits follow semantic (conventional) commit |
dfbb5eb to
75241b2
Compare
Author
|
@bhushan-barbuddhe Fixed the pre-commit issues and amended the commit message to follow semantic conventions. CI should pass now. |
bhushan-barbuddhe
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR patches frappe.breadcrumbs.update to handle a Frappe v15 behavior where this.all is not populated for Query Reports. Without this patch, opening query reports results in a TypeError when trying to read properties of undefined (e.g., HR, Projects).
Changes included:
Added a safe patch that preserves the original frappe.breadcrumbs.update for cases where this.all[page] is undefined.
Ensures breadcrumbs are properly displayed for Forms, Lists, and Dashboard views.
Compatible with Frappe v15 and does not affect other apps or previous behavior.
Files modified:
public/js/sidebar/breadcrumb_override_patch.js
Issue fixed:
Prevents Uncaught TypeError: Cannot read properties of undefined (reading 'HR') in Query Reports.
Testing:
Verified in Frappe v15 with Query Reports and standard List/Form views.
Breadcrumbs render correctly and no errors in console.