fix: declare Frappe v15 compatibility#9
Closed
vaishalisahni wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@vaishalisahni please share PR against develop branch |
Author
|
@bhushan-barbuddhe The compatibility issue I encountered was on the main branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR fixes Frappe Framework v15 compatibility for the frappe-desk-theme app by declaring the supported framework version in pyproject.toml.
The main branch did not specify any Frappe dependency, which caused Frappe Cloud and Bench v15 to block installation and branch switching due to missing compatibility metadata.
Issue- #8
Solution
This PR makes the app explicitly compatible with Frappe Framework v15 by adding the required dependency declaration.
The following change was made:
Declared Frappe framework compatibility in pyproject.toml using:
frappe>=15,<16This ensures that Frappe Cloud and Bench can correctly validate and allow installation of the app on Frappe v15 environments.