What problem are you hitting
Crisp's BrightnessKeyService only listens for keyDown keycodes 144/145 in the raw-keyDown fallback path. On Logitech MX Keys, pressing the brightness keys (F1/F2, media-key mode, Logi Options+ set to media keys) produces keyDown keycode 107 (F14) and 113 (F15) — which Crisp ignores, so external-display brightness keys do nothing (MonitorControl's MediaKeyTap maps 107/113, see functionKeyCodeToMediaKey).
Repro: macOS 15/26, Mac mini + external display, MX Keys. Grant Accessibility → Brightness Keys menu shows → press F1/F2 → nothing. Verified via CGEventTap dump: KEYDOWN keycode=107 / 113. Cmd+F1 works because it triggers an NX_SYSDEFINED brightness event (key=3) that the NX path does handle.
What do you suggest
add case 107/113 to the keyDown fallback (or a useAlternateBrightnessKeys flag like MediaKeyTap).
What do you do today
No response
What problem are you hitting
Crisp's BrightnessKeyService only listens for keyDown keycodes 144/145 in the raw-keyDown fallback path. On Logitech MX Keys, pressing the brightness keys (F1/F2, media-key mode, Logi Options+ set to media keys) produces keyDown keycode 107 (F14) and 113 (F15) — which Crisp ignores, so external-display brightness keys do nothing (MonitorControl's MediaKeyTap maps 107/113, see functionKeyCodeToMediaKey).
Repro: macOS 15/26, Mac mini + external display, MX Keys. Grant Accessibility → Brightness Keys menu shows → press F1/F2 → nothing. Verified via CGEventTap dump: KEYDOWN keycode=107 / 113. Cmd+F1 works because it triggers an NX_SYSDEFINED brightness event (key=3) that the NX path does handle.
What do you suggest
add case 107/113 to the keyDown fallback (or a useAlternateBrightnessKeys flag like MediaKeyTap).
What do you do today
No response