pbench-register-tool -g does not respect tools listed in groups

[aokuliar-rh]

pbench-agent-0.71.0-185g5527f23f1.noarch

1. add another group to pbench configuration file

[pbench/tools]
default-tool-set = sar, iostat, mpstat, pidstat, proc-vmstat, proc-interrupts, turbostat, perf, turbostat
another-tool-set = sar, iostat,pidstat, proc-vmstat, proc-interrupts, turbostat, perf

2. run pbench-register-tool-set

"sar" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "default"
"iostat" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "default"
"mpstat" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "default"
"pidstat" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "default"
"proc-vmstat" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "default"
"proc-interrupts" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "default"
"turbostat" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "default"
"perf" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "default"

3. run pbench-register-tool-set -g another

"sar" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "another"
"iostat" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "another"
"mpstat" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "another"
"pidstat" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "another"
"proc-vmstat" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "another"
"proc-interrupts" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "another"
"turbostat" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "another"
"perf" tool is now registered for host "vales1.slevarna.tpb.lab.eng.brq.redhat.com" in group "another"

please note, that mpstat has been registered to another group, event if it is not listed in another group in configuration file

[riya-17]

[root@dhcp31-107 util-scripts]# pbench-list-tools 
default: iostat,mpstat,perf,pidstat,proc-interrupts,proc-vmstat,sar,turbostat
[root@dhcp31-107 util-scripts]# pbench-register-tool-set --toolset=another -g light
sar: pbench-sysstat-12.0.3 is installed
sar tool is now registered in group light
iostat: pbench-sysstat-12.0.3 is installed
iostat tool is now registered in group light
mpstat: pbench-sysstat-12.0.3 is installed
mpstat tool is now registered in group light
pidstat: pbench-sysstat-12.0.3 is installed
pidstat tool is now registered in group light
proc-vmstat tool is now registered in group light
[root@dhcp31-107 util-scripts]# 
[root@dhcp31-107 util-scripts]# pbench-list-tools 
default: iostat,mpstat,perf,pidstat,proc-interrupts,proc-vmstat,sar,turbostat
light: iostat,mpstat,pidstat,proc-vmstat,sar

@portante @ndokos I got this result from the following command. Seems to be working fine. Can you take a look? Maybe I am missing something.

[npalaska]

I concur with Riya and I think this issue can be closed since the use case mentioned in the description seems to be incorrect. If the tool-set is specified in the config file we use --toolset option to register those tools (without --group option in will be under default group and with --group option it will be registered under that group name)

[webbnh]

Yes, I think, @aokuliar-rh, you got what you asked for:

pbench-register-tool-set -g another

This will add the default tool set to the another tool group. If you want a different tool set for that group, you need to specify the set you want, e.g.:

pbench-register-tool-set --toolset=another -g another

(And, by the way, @aokuliar-rh, you have turbostat listed twice in your default-tool-set. 🙂)

[ndokos]

We believe that this is a documentation issue, not a code issue. We need to update the User Guide.

[aokuliar-rh]

I retested this with pbench-agent-0.71.0-13g894ea5d0f.noarch and it works exactly as @webbnh mentioned.

pbench-register-tool-set --toolset=another -g another
works perfectly.

It was a misunderstanding from my side. It was not a clear how realtion of tool sets and groups works. I am closing this.
Webb, thank you for the explanation. It would be perfect if someone clarify this in documentation.

[portante]

Re-opening to fix documentation.