"disk_health" considered "admin failed" disk as normal

[ChungHungChen]

Issue Type

Bug report

Issue Detail

• check_netapp_ontap version: v3.04.201124
• NetApp Ontap version: 9.6.0 ( simulator, 2 nodes )
• Monitoring solution: LibreNMS

Expected Behavior
When a disk failed, "disk_health" change to warning due to reconstructing.
After reconstruct completed, "disk_health" should keep warning state because of a failed disk in list.

Actual Behavior
After reconstruct completed, "disk_health" become normal but there is a failed disk in list.

Edit: I've tried add "-w 1" to set warning level at 1 failed disk"
Edit2: Sorry, I didn't notice that "disk_health" can't set warning / critical level, only "disk_spare" can.

How to reproduce Behavior
Fail a disk manually and wait for reconstruct completed, check the exit code from "disk_health".

[ChungHungChen]

Hi, I've modified and tested with below patch and it works well now.
Thanks.

--- check_netapp_ontap.pl.orig  2021-02-18 17:34:35.348575799 +0800
+++ check_netapp_ontap.pl       2021-02-18 17:38:49.078706791 +0800
@@ -102,7 +102,7 @@
        my $intObjectCount = 0;
        my $strOutput;

-       my @aryFDRWarning = ("bypassed", "label version", "labeled broken", "LUN resized", "missing", "predict failure", "rawsize shrank", "recovering", "sanitizing", "unassigned");
+       my @aryFDRWarning = ("bypassed", "label version", "labeled broken", "LUN resized", "missing", "predict failure", "rawsize shrank", "recovering", "sanitizing", "unassigned", "admin failed");
        my @aryFDRCritical = ("bad label", "failed", "init failed", "not responding", "unknown");

        foreach my $strDisk (keys %$hrefDiskInfo) {