Fix Issue 15896 - private ignored when import bindings are used

Author: RazvanN7

src/ddmd/dimport.d

@@ -13,6 +13,7 @@ module ddmd.dimport;
 import core.stdc.string;
 import core.stdc.stdio;
 
+import ddmd.access;
 import ddmd.arraytypes;
 import ddmd.declaration;
 import ddmd.dmodule;
@@ -244,7 +245,7 @@ extern (C++) final class Import : Dsymbol
         if (mod)
         {
             // Modules need a list of each imported module
-            //printf("%s imports %s\n", sc.module.toChars(), mod.toChars());
+            //printf("%s imports %s\n", sc._module.toChars(), mod.toChars());
             sc._module.aimports.push(mod);
 
             if (sc.explicitProtection)
@@ -295,10 +296,15 @@ extern (C++) final class Import : Dsymbol
             for (size_t i = 0; i < aliasdecls.dim; i++)
             {
                 AliasDeclaration ad = aliasdecls[i];
-                //printf("\tImport %s alias %s = %s, scope = %p\n", toPrettyChars(), aliases[i].toChars(), names[i].toChars(), ad._scope);
-                if (mod.search(loc, names[i]))
+                //printf("\tImport %s alias %s = %s, scope = %p\n", toPrettyChars(), aliasdecls[i].toChars(), names[i].toChars(), ad._scope);
+                Dsymbol importedSymbol = mod.search(loc, names[i]);
+                if (importedSymbol)
                 {
-                    ad.semantic(sc);
+                    // BUGZILLA 15896 : if symbol is private then it shouldn't be accessed
+                    if(importedSymbol.prot().kind == PROTprivate)
+                        mod.error(loc, "member '%s' is private", names[i].toChars());
+                    else
+                        ad.semantic(sc);
                     // If the import declaration is in non-root module,
                     // analysis of the aliased symbol is deferred.
                     // Therefore, don't see the ad.aliassym or ad.type here.
@@ -307,7 +313,9 @@ extern (C++) final class Import : Dsymbol
                 {
                     Dsymbol s = mod.search_correct(names[i]);
                     if (s)
+                    {
                         mod.error(loc, "import '%s' not found, did you mean %s '%s'?", names[i].toChars(), s.kind(), s.toChars());
+                    }
                     else
                         mod.error(loc, "import '%s' not found", names[i].toChars());
                     ad.type = Type.terror;

src/ddmd/expression.d

@@ -6584,7 +6584,7 @@ extern (C++) final class VarExp : SymbolExp
          * problems when instantiating imported templates passing private
          * variables as alias template parameters.
          */
-        //checkAccess(loc, sc, NULL, var);
+        //checkAccess(loc, sc, null, var);
 
         if (auto vd = var.isVarDeclaration())
         {

test/fail_compilation/fail15896.d

@@ -0,0 +1,14 @@
+/*
+TEST_OUTPUT:
+---
+fail_compilation/fail15896.d(8): Error: module imports.imp15896 member 'thebar' is private
+---
+*/
+
+import imports.imp15896 : thebar;
+
+int func()
+{
+    thebar +=1;
+    return 0;
+}

test/fail_compilation/imports/imp15896.d

@@ -0,0 +1,3 @@
+module imports.imp15896;
+
+private int thebar=4;