Improve coverage + changelog

Author: wilzbach

changelog/uda-function-arguments.dd

@@ -0,0 +1,10 @@
+UDAs on function arguments are now supported
+
+User-defined attributes on function arguments behave analogous to existing UDAs:
+
+---
+void test(A)(@(22) A a)
+{
+    static assert([__traits(getAttributes, a)] == [22]);
+}
+---

src/dmd/parse.d

@@ -2778,7 +2778,7 @@ final class Parser(AST) : Lexer
                         StorageClass stc2 = parseAttribute(&exps);
                         if (stc2 == AST.STC.property || stc2 == AST.STC.nogc || stc2 == AST.STC.disable || stc2 == AST.STC.safe || stc2 == AST.STC.trusted || stc2 == AST.STC.system)
                         {
-                            error("@%s attribute for function parameter is not supported", token.toChars());
+                            error("`@%s` attribute for function parameter is not supported", token.toChars());
                         }
                         else
                         {
@@ -2865,6 +2865,7 @@ final class Parser(AST) : Lexer
                     }
                 default:
                     {
+                        int i = 1;
                         stc = storageClass & (AST.STC.in_ | AST.STC.out_ | AST.STC.ref_ | AST.STC.lazy_);
                         // if stc is not a power of 2
                         if (stc & (stc - 1) && !(stc == (AST.STC.in_ | AST.STC.ref_)))
@@ -2920,7 +2921,7 @@ final class Parser(AST) : Lexer
                             StorageClass stc2 = parseAttribute(&exps);
                             if (stc2 == AST.STC.property || stc2 == AST.STC.nogc || stc2 == AST.STC.disable || stc2 == AST.STC.safe || stc2 == AST.STC.trusted || stc2 == AST.STC.system)
                             {
-                                error("@%s attribute for function parameter is not supported", token.toChars());
+                                error("`@%s` attribute for function parameter is not supported", token.toChars());
                             }
                             else
                             {

src/dmd/traits.d

@@ -719,7 +719,7 @@ extern (C++) Expression semanticTraits(TraitsExp e, Scope* sc)
         {
             if (!po.ident)
             {
-                e.error("argument %s has no identifier", po.type.toChars());
+                e.error("argument `%s` has no identifier", po.type.toChars());
                 return new ErrorExp();
             }
             id = po.ident;

test/fail_compilation/udaparams.d

@@ -1,14 +1,17 @@
 /*
 TEST_OUTPUT:
 ---
-fail_compilation/udaparams.d(15): Error: variadic parameter cannot have user-defined attributes
-fail_compilation/udaparams.d(16): Error: variadic parameter cannot have user-defined attributes
-fail_compilation/udaparams.d(18): Error: user-defined attributes cannot appear as postfixes
-fail_compilation/udaparams.d(19): Error: user-defined attributes cannot appear as postfixes
-fail_compilation/udaparams.d(20): Error: user-defined attributes cannot appear as postfixes
-fail_compilation/udaparams.d(22): Error: @safe attribute for function parameter is not supported
-fail_compilation/udaparams.d(23): Error: @safe attribute for function parameter is not supported
-fail_compilation/udaparams.d(24): Error: @safe attribute for function parameter is not supported
+fail_compilation/udaparams.d(18): Error: variadic parameter cannot have user-defined attributes
+fail_compilation/udaparams.d(19): Error: variadic parameter cannot have user-defined attributes
+fail_compilation/udaparams.d(21): Error: user-defined attributes cannot appear as postfixes
+fail_compilation/udaparams.d(22): Error: user-defined attributes cannot appear as postfixes
+fail_compilation/udaparams.d(23): Error: user-defined attributes cannot appear as postfixes
+fail_compilation/udaparams.d(25): Error: `@safe` attribute for function parameter is not supported
+fail_compilation/udaparams.d(26): Error: `@safe` attribute for function parameter is not supported
+fail_compilation/udaparams.d(27): Error: `@safe` attribute for function parameter is not supported
+fail_compilation/udaparams.d(30): Error: `@system` attribute for function parameter is not supported
+fail_compilation/udaparams.d(31): Error: `@trusted` attribute for function parameter is not supported
+fail_compilation/udaparams.d(32): Error: `@nogc` attribute for function parameter is not supported
 ---
 */
 
@@ -22,3 +25,8 @@ void rhsuda3(int[] arr @(10) ...);
 void wrongAttr1(@safe int);
 void wrongAttr2(@safe void function());
 void wrongAttr3(@safe void delegate());
+
+
+void test16(A)(A a @system);
+void test16(A)(A a @trusted);
+void test16(A)(A a @nogc);