From edfd04a0173968ef3b148e9c5dd40229d113c4c4 Mon Sep 17 00:00:00 2001 From: "daniel.natali" Date: Mon, 21 Aug 2017 17:49:42 -0300 Subject: [PATCH 1/3] Added log to the service classes. --- .gitignore | 4 ++++ README.md | 1 + .../sample/spring/services/ComponentService.java | 6 +++++- .../antipattern/sample/spring/services/StatusService.java | 4 ++++ 4 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 README.md diff --git a/.gitignore b/.gitignore index 32858aa..91644f5 100644 --- a/.gitignore +++ b/.gitignore @@ -10,3 +10,7 @@ # virtual machine crash logs, see http://www.java.com/en/download/help/error_hotspot.xml hs_err_pid* +/target/ +/bin/ +/.classpath +/.project diff --git a/README.md b/README.md new file mode 100644 index 0000000..b186738 --- /dev/null +++ b/README.md @@ -0,0 +1 @@ +This is the begining of the README file \ No newline at end of file diff --git a/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java b/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java index 7f20392..5e0909e 100644 --- a/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java +++ b/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java @@ -19,10 +19,14 @@ public ComponentHelper getHelper() { } public String getComponentDetails(String component) { + + System.out.println("Entering component details method"); + System.out.println("Trying to find" + component + " details."); + return helper.findComponentDetails(component); } - public void saveComponent(Component component) { + public void saveComponent(Component component) { System.out.println("Saving component"); } diff --git a/src/main/java/com/aurea/antipattern/sample/spring/services/StatusService.java b/src/main/java/com/aurea/antipattern/sample/spring/services/StatusService.java index 3fe3f99..c35ad42 100644 --- a/src/main/java/com/aurea/antipattern/sample/spring/services/StatusService.java +++ b/src/main/java/com/aurea/antipattern/sample/spring/services/StatusService.java @@ -13,10 +13,14 @@ public class StatusService { private StatusRepository statusRepository; public Iterable getStatusForAllComponents() { + System.out.println("Getting status for all components.."); return statusRepository.findAll(); } public Status getStatusByComponent(String component) { + + System.out.println("Find status for" + component); + return statusRepository.findByComponent(component); } } From 372e4008675cc62fe3a6b2064e3ff02324599fbb Mon Sep 17 00:00:00 2001 From: "daniel.natali" Date: Mon, 21 Aug 2017 18:28:34 -0300 Subject: [PATCH 2/3] Fix bug for saving components --- .../aurea/antipattern/sample/spring/bean/Component.java | 8 ++++++++ .../sample/spring/repository/ComponentRepository.java | 9 +++++++++ .../sample/spring/services/ComponentService.java | 5 ++++- 3 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 src/main/java/com/aurea/antipattern/sample/spring/repository/ComponentRepository.java diff --git a/src/main/java/com/aurea/antipattern/sample/spring/bean/Component.java b/src/main/java/com/aurea/antipattern/sample/spring/bean/Component.java index 3c24f77..c0006b7 100644 --- a/src/main/java/com/aurea/antipattern/sample/spring/bean/Component.java +++ b/src/main/java/com/aurea/antipattern/sample/spring/bean/Component.java @@ -2,8 +2,16 @@ import java.util.Date; +import javax.persistence.Entity; +import javax.persistence.GeneratedValue; +import javax.persistence.GenerationType; +import javax.persistence.Id; + +@Entity public class Component { + @Id + @GeneratedValue(strategy=GenerationType.AUTO) private Long id; private String name; private String author; diff --git a/src/main/java/com/aurea/antipattern/sample/spring/repository/ComponentRepository.java b/src/main/java/com/aurea/antipattern/sample/spring/repository/ComponentRepository.java new file mode 100644 index 0000000..3dfe78b --- /dev/null +++ b/src/main/java/com/aurea/antipattern/sample/spring/repository/ComponentRepository.java @@ -0,0 +1,9 @@ +package com.aurea.antipattern.sample.spring.repository; + +import org.springframework.data.repository.CrudRepository; + +import com.aurea.antipattern.sample.spring.bean.Component; + +public interface ComponentRepository extends CrudRepository { + +} diff --git a/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java b/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java index 7f20392..a9af5b9 100644 --- a/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java +++ b/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java @@ -4,11 +4,14 @@ import com.aurea.antipattern.sample.spring.bean.Component; import com.aurea.antipattern.sample.spring.helper.ComponentHelper; +import com.aurea.antipattern.sample.spring.repository.ComponentRepository; @Service public class ComponentService { private ComponentHelper helper; + private ComponentRepository compomentRepository; + public void setHelper(ComponentHelper helper) { this.helper = helper; @@ -23,7 +26,7 @@ public String getComponentDetails(String component) { } public void saveComponent(Component component) { - System.out.println("Saving component"); + compomentRepository.save(component); } } From 5b4da5e2262550b081780671dda092f2d431121f Mon Sep 17 00:00:00 2001 From: "daniel.natali" Date: Mon, 21 Aug 2017 18:52:20 -0300 Subject: [PATCH 3/3] Fix PR reviews --- pom.xml | 7 +++- .../spring/services/ComponentService.java | 37 ++++++++++--------- .../sample/spring/services/StatusService.java | 29 ++++++++------- 3 files changed, 41 insertions(+), 32 deletions(-) diff --git a/pom.xml b/pom.xml index fbc9ea0..6c13ca8 100644 --- a/pom.xml +++ b/pom.xml @@ -58,7 +58,12 @@ com.h2database h2 - + + org.projectlombok + lombok + 1.16.16 + provided + diff --git a/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java b/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java index 5e0909e..3b9d6b0 100644 --- a/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java +++ b/src/main/java/com/aurea/antipattern/sample/spring/services/ComponentService.java @@ -5,29 +5,32 @@ import com.aurea.antipattern.sample.spring.bean.Component; import com.aurea.antipattern.sample.spring.helper.ComponentHelper; +import lombok.extern.log4j.Log4j; + @Service +@Log4j public class ComponentService { - private ComponentHelper helper; + private ComponentHelper helper; + + public void setHelper(ComponentHelper helper) { + this.helper = helper; + } + + public ComponentHelper getHelper() { + return helper; + } - public void setHelper(ComponentHelper helper) { - this.helper = helper; - } + public String getComponentDetails(String component) { - public ComponentHelper getHelper() { - return helper; - } + log.debug("Entering component details method"); + log.debug("Trying to find" + component + " details."); - public String getComponentDetails(String component) { - - System.out.println("Entering component details method"); - System.out.println("Trying to find" + component + " details."); - - return helper.findComponentDetails(component); - } + return helper.findComponentDetails(component); + } - public void saveComponent(Component component) { - System.out.println("Saving component"); - } + public void saveComponent(Component component) { + log.debug("Saving component"); + } } diff --git a/src/main/java/com/aurea/antipattern/sample/spring/services/StatusService.java b/src/main/java/com/aurea/antipattern/sample/spring/services/StatusService.java index c35ad42..b1b6102 100644 --- a/src/main/java/com/aurea/antipattern/sample/spring/services/StatusService.java +++ b/src/main/java/com/aurea/antipattern/sample/spring/services/StatusService.java @@ -6,21 +6,22 @@ import com.aurea.antipattern.sample.spring.bean.Status; import com.aurea.antipattern.sample.spring.repository.StatusRepository; +import lombok.extern.log4j.Log4j; + @Service +@Log4j public class StatusService { - @Autowired - private StatusRepository statusRepository; - - public Iterable getStatusForAllComponents() { - System.out.println("Getting status for all components.."); - return statusRepository.findAll(); - } - - public Status getStatusByComponent(String component) { - - System.out.println("Find status for" + component); - - return statusRepository.findByComponent(component); - } + @Autowired + private StatusRepository statusRepository; + + public Iterable getStatusForAllComponents() { + log.debug("Getting status for all components.."); + return statusRepository.findAll(); + } + + public Status getStatusByComponent(String component) { + log.debug("Find status for" + component); + return statusRepository.findByComponent(component); + } }