From 37b6b360ee460552a01ce90d23cee2d47392b2e6 Mon Sep 17 00:00:00 2001
From: docushell-admin <hello@docushell.com>
Date: Wed, 17 Jun 2026 10:12:15 +0530
Subject: [PATCH] Fail closed on stale chunk warning refs

Signed-off-by: docushell-admin <hello@docushell.com>
---
 crates/ethos-cli/src/cmd/rag.rs |  16 +++--
 crates/ethos-cli/tests/rag.rs   | 100 ++++++++++++++++++++++++++++++++
 2 files changed, 110 insertions(+), 6 deletions(-)
 create mode 100644 crates/ethos-cli/tests/rag.rs

diff --git a/crates/ethos-cli/src/cmd/rag.rs b/crates/ethos-cli/src/cmd/rag.rs
index b77dd2a..1249a85 100644
--- a/crates/ethos-cli/src/cmd/rag.rs
+++ b/crates/ethos-cli/src/cmd/rag.rs
@@ -96,12 +96,16 @@ fn rag_chunk_record(doc: &Document, chunk: &Chunk) -> Result<serde_json::Value,
         serde_json::to_value(&chunk.token_estimate)
             .map_err(|e| EthosError::internal(e.to_string()))?,
     );
-    let warnings: Vec<serde_json::Value> = chunk
-        .warning_refs
-        .iter()
-        .filter_map(|id| warning_code(id))
-        .map(|c| serde_json::Value::String(c.to_string()))
-        .collect();
+    let mut warnings = Vec::with_capacity(chunk.warning_refs.len());
+    for id in &chunk.warning_refs {
+        let Some(code) = warning_code(id) else {
+            return Err(Failure::Usage(format!(
+                "chunk {} references unknown warning_ref {}",
+                chunk.id, id
+            )));
+        };
+        warnings.push(serde_json::Value::String(code.to_string()));
+    }
     record.insert("warnings".into(), serde_json::Value::Array(warnings));
     Ok(serde_json::Value::Object(record))
 }
diff --git a/crates/ethos-cli/tests/rag.rs b/crates/ethos-cli/tests/rag.rs
new file mode 100644
index 0000000..40d9157
--- /dev/null
+++ b/crates/ethos-cli/tests/rag.rs
@@ -0,0 +1,100 @@
+/*
+ * Copyright 2026 The Ethos maintainers
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+use std::path::{Path, PathBuf};
+use std::process::{Command, Output};
+use std::time::{SystemTime, UNIX_EPOCH};
+
+use ethos_core::model::Document;
+use serde_json::Value;
+
+fn ethos_bin() -> &'static str {
+    env!("CARGO_BIN_EXE_ethos")
+}
+
+fn repo_root() -> PathBuf {
+    Path::new(env!("CARGO_MANIFEST_DIR")).join("../..")
+}
+
+fn document_example() -> PathBuf {
+    repo_root().join("schemas/examples/document.example.json")
+}
+
+fn chunks_example() -> PathBuf {
+    repo_root().join("schemas/examples/chunks.example.jsonl")
+}
+
+fn run_ethos(args: &[&str]) -> Output {
+    Command::new(ethos_bin())
+        .args(args)
+        .output()
+        .expect("ethos command runs")
+}
+
+fn json_file(path: impl AsRef<Path>) -> Value {
+    let bytes = std::fs::read(path).expect("JSON fixture is readable");
+    serde_json::from_slice(&bytes).expect("JSON fixture parses")
+}
+
+fn temp_json(name: &str, json: &str) -> PathBuf {
+    let nanos = SystemTime::now()
+        .duration_since(UNIX_EPOCH)
+        .expect("clock after unix epoch")
+        .as_nanos();
+    let path = std::env::temp_dir().join(format!("ethos-{name}-{nanos}.json"));
+    std::fs::write(&path, json).expect("temp JSON is writable");
+    path
+}
+
+fn document_with_stale_chunk_warning_ref() -> PathBuf {
+    let mut doc = json_file(document_example());
+    doc["payload"]["chunks"][0]["warning_refs"] = serde_json::json!(["w999999"]);
+
+    let mut doc: Document = serde_json::from_value(doc).expect("document parses");
+    doc.payload_sha256 = doc.compute_payload_sha256().expect("payload hash computes");
+    doc.fingerprint = doc.compute_fingerprint().expect("fingerprint computes");
+    temp_json(
+        "stale-chunk-warning-ref-document",
+        &serde_json::to_string(&doc).expect("document serializes"),
+    )
+}
+
+#[test]
+fn rag_chunk_matches_schema_example_jsonl() {
+    let output = run_ethos(&["rag", "chunk", document_example().to_str().unwrap()]);
+
+    assert!(
+        output.status.success(),
+        "ethos rag chunk failed\nstatus: {:?}\nstderr:\n{}",
+        output.status.code(),
+        String::from_utf8_lossy(&output.stderr)
+    );
+    assert_eq!(output.stderr, b"");
+
+    let expected = std::fs::read(chunks_example()).expect("chunks example is readable");
+    assert_eq!(output.stdout, expected);
+}
+
+#[test]
+fn rag_chunk_rejects_unknown_chunk_warning_ref() {
+    let document = document_with_stale_chunk_warning_ref();
+    let output = run_ethos(&["rag", "chunk", document.to_str().unwrap()]);
+
+    assert_eq!(output.status.code(), Some(2));
+    assert_eq!(output.stdout, b"");
+    assert!(String::from_utf8_lossy(&output.stderr)
+        .contains("chunk c000001 references unknown warning_ref w999999"));
+}