fix: replace URLSearchParams with manual query parsing in mcp-oauth callback#136
Merged
Conversation
ctx.request.query is already a parsed map[string]string provided by Go's URL.Query() — no need for URLSearchParams or manual parsing. The original code failed because URLSearchParams is not available in the goja runtime. Adds integration tests that load the real mcp-oauth plugin source through the goja VM to catch runtime API incompatibilities.
donbader
force-pushed
the
fix/mcp-oauth-urlsearchparams
branch
from
31f7583 to
e342196
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gateway JS runtime (goja) does not provide Web Platform APIs like
URLSearchParams. The OAuth callback handler was usingnew URLSearchParams(query)which threwReferenceError: URLSearchParams is not definedwhen the browser redirected back after authorization.Fix: Replace with a
parseQuery()helper that uses only core ECMAScript (split,decodeURIComponent) which goja supports natively.Tested: All tests pass (
go test ./...).