fix: replace URLSearchParams with manual query parsing in mcp-oauth callback

core/gateway/internal/pluginloader/mcp_oauth_test.go

@@ -0,0 +1,208 @@
+package pluginloader
+
+import (
+	"net/http"
+	"net/http/httptest"
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/donbader/agent-sandbox/core/sdk/gateway"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+// TestMcpOAuth_CallbackQueryParsing verifies that the mcp-oauth callback handler
+// can parse query parameters from the request without using Web APIs (URLSearchParams)
+// that are unavailable in the goja JS runtime.
+func TestMcpOAuth_CallbackQueryParsing(t *testing.T) {
+	gateway.ResetForTesting()
+
+	// Point to the real mcp-oauth plugin source
+	pluginDir, err := filepath.Abs("../../../plugins/mcp-oauth")
+	require.NoError(t, err)
+
+	// Verify the plugin source exists
+	_, err = os.Stat(filepath.Join(pluginDir, "src", "callback.ts"))
+	require.NoError(t, err, "mcp-oauth callback.ts not found at %s", pluginDir)
+
+	cfg := &PluginsConfig{
+		Plugins: []PluginConfig{
+			{
+				Name: "mcp-oauth",
+				Dir:  pluginDir,
+				Options: map[string]any{
+					"providers": map[string]any{
+						"notion": map[string]any{
+							"mcp_url": "https://mcp.notion.com/mcp",
+						},
+					},
+					"callback_url": "http://127.0.0.1:8080/plugins/mcp-oauth/callback",
+					"token_dir":    t.TempDir(),
+				},
+				Gateway: GatewayContrib{
+					Routes: []RouteEntry{
+						{Path: "/callback", Handler: "./src/callback.ts"},
+					},
+				},
+			},
+		},
+	}
+
+	err = LoadPlugins(cfg)
+	require.NoError(t, err)
+
+	handler := gateway.MatchRoute("/plugins/mcp-oauth/callback")
+	require.NotNil(t, handler)
+
+	// Simulate OAuth callback with code and state query params.
+	// The state won't be valid, so we expect a 403 "invalid state signature" —
+	// but crucially, NOT a JS runtime error like "URLSearchParams is not defined".
+	req, _ := http.NewRequest("GET", "http://127.0.0.1:8080/plugins/mcp-oauth/callback?code=testcode123&state=invalidsig:notion", nil)
+	w := httptest.NewRecorder()
+	handler(w, req)
+
+	// Should get a domain-logic error (403 invalid state), NOT a 500 plugin error
+	assert.Equal(t, 403, w.Code, "expected 403 for invalid state, got %d: %s", w.Code, w.Body.String())
+	assert.Contains(t, w.Body.String(), "invalid state")
+}
+
+// TestMcpOAuth_CallbackMissingCode verifies handling of missing code parameter.
+func TestMcpOAuth_CallbackMissingCode(t *testing.T) {
+	gateway.ResetForTesting()
+
+	pluginDir, err := filepath.Abs("../../../plugins/mcp-oauth")
+	require.NoError(t, err)
+
+	cfg := &PluginsConfig{
+		Plugins: []PluginConfig{
+			{
+				Name: "mcp-oauth",
+				Dir:  pluginDir,
+				Options: map[string]any{
+					"providers":    map[string]any{},
+					"callback_url": "http://127.0.0.1:8080/plugins/mcp-oauth/callback",
+					"token_dir":    t.TempDir(),
+				},
+				Gateway: GatewayContrib{
+					Routes: []RouteEntry{
+						{Path: "/callback", Handler: "./src/callback.ts"},
+					},
+				},
+			},
+		},
+	}
+
+	err = LoadPlugins(cfg)
+	require.NoError(t, err)
+
+	handler := gateway.MatchRoute("/plugins/mcp-oauth/callback")
+	require.NotNil(t, handler)
+
+	// No code param — should get 400, not a runtime error
+	req, _ := http.NewRequest("GET", "http://127.0.0.1:8080/plugins/mcp-oauth/callback?state=foo", nil)
+	w := httptest.NewRecorder()
+	handler(w, req)
+
+	assert.Equal(t, 400, w.Code)
+	assert.Contains(t, w.Body.String(), "missing code")
+}
+
+// TestMcpOAuth_LoginHandler verifies the login route doesn't crash on
+// ES6 APIs (Object.keys, string methods, etc.) in the goja runtime.
+func TestMcpOAuth_LoginHandler(t *testing.T) {
+	gateway.ResetForTesting()
+
+	pluginDir, err := filepath.Abs("../../../plugins/mcp-oauth")
+	require.NoError(t, err)
+
+	cfg := &PluginsConfig{
+		Plugins: []PluginConfig{
+			{
+				Name: "mcp-oauth",
+				Dir:  pluginDir,
+				Options: map[string]any{
+					"providers": map[string]any{
+						"notion": map[string]any{
+							"mcp_url": "https://mcp.notion.com/mcp",
+						},
+					},
+					"callback_url": "http://127.0.0.1:8080/plugins/mcp-oauth/callback",
+					"token_dir":    t.TempDir(),
+				},
+				Gateway: GatewayContrib{
+					Routes: []RouteEntry{
+						{Path: "/login", Handler: "./src/login.ts"},
+					},
+				},
+			},
+		},
+	}
+
+	err = LoadPlugins(cfg)
+	require.NoError(t, err)
+
+	handler := gateway.MatchRoute("/plugins/mcp-oauth/login")
+	require.NotNil(t, handler)
+
+	// Request login for a provider that has no client_id — will attempt discovery.
+	// Discovery will fail (no server), but the JS should execute without runtime errors.
+	req, _ := http.NewRequest("GET", "http://127.0.0.1:8080/plugins/mcp-oauth/login/notion", nil)
+	w := httptest.NewRecorder()
+	handler(w, req)
+
+	// Should NOT be a 500 with "plugin error: TypeError/ReferenceError"
+	body := w.Body.String()
+	assert.NotContains(t, body, "ReferenceError", "JS runtime error: %s", body)
+	assert.NotContains(t, body, "TypeError", "JS runtime error: %s", body)
+}
+
+// TestMcpOAuth_OAuthMiddleware verifies the oauth middleware doesn't crash
+// on Object.entries or other ES6 runtime APIs in goja.
+func TestMcpOAuth_OAuthMiddleware(t *testing.T) {
+	gateway.ResetForTesting()
+
+	pluginDir, err := filepath.Abs("../../../plugins/mcp-oauth")
+	require.NoError(t, err)
+
+	cfg := &PluginsConfig{
+		Plugins: []PluginConfig{
+			{
+				Name: "mcp-oauth",
+				Dir:  pluginDir,
+				Options: map[string]any{
+					"providers": map[string]any{
+						"notion": map[string]any{
+							"mcp_url": "https://mcp.notion.com/mcp",
+						},
+					},
+					"callback_url": "http://127.0.0.1:8080/plugins/mcp-oauth/callback",
+					"token_dir":    t.TempDir(),
+				},
+				Gateway: GatewayContrib{
+					Middlewares: []MiddlewareEntry{
+						{Script: "./src/oauth.ts", Domains: []string{"mcp.notion.com"}},
+					},
+				},
+			},
+		},
+	}
+
+	err = LoadPlugins(cfg)
+	require.NoError(t, err)
+
+	all := gateway.All()
+	require.Len(t, all, 1)
+
+	// Request to mcp.notion.com — no token file exists, so it will abort with 401.
+	// The important thing is it doesn't crash with a TypeError on Object.entries.
+	req, _ := http.NewRequest("GET", "https://mcp.notion.com/mcp", nil)
+	req.Host = "mcp.notion.com"
+	ctx := &gateway.MiddlewareContext{Request: req, Env: os.Getenv}
+	err = all[0].Func(ctx)
+
+	require.NoError(t, err, "middleware should not return a Go error")
+	// Should abort with 401 (no token), not crash
+	assert.Equal(t, 401, ctx.AbortStatus)
+	assert.Contains(t, ctx.AbortBody, "oauth_required")
+}

core/plugins/mcp-oauth/src/callback.ts

@@ -95,10 +95,9 @@ export default function(ctx: any, options: any) {
   const callbackURL = options.callback_url || "";
   const providersJSON = JSON.stringify(providers);
 
-  const query = ctx.request.query || "";
-  const params = new URLSearchParams(query);
-  const code = params.get("code");
-  const state = params.get("state");
+  const query = ctx.request.query || {};
+  const code = query["code"] || null;
+  const state = query["state"] || null;
 
   if (!code) {
     ctx.response.status(400);