From cd10c32d67c9e364a116f27bb82deda97a13a5f1 Mon Sep 17 00:00:00 2001 From: Roman Gershman Date: Mon, 1 Jun 2026 14:03:25 +0300 Subject: [PATCH 1/2] chore: enable rdb_sbf_chunked by default The chunked SBF save format has been validated. Flip the default to true and remove explicit flag overrides in tests. --- src/server/rdb_save.cc | 3 +-- src/server/rdb_test.cc | 1 - tests/dragonfly/replication_test.py | 2 -- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/server/rdb_save.cc b/src/server/rdb_save.cc index adbd4697f6db..df0ea453246f 100644 --- a/src/server/rdb_save.cc +++ b/src/server/rdb_save.cc @@ -53,8 +53,7 @@ ABSL_FLAG(dfly::CompressionMode, compression_mode, dfly::CompressionMode::MULTI_ "set 2 for multi entry zstd compression on df snapshot and single entry on rdb snapshot," "set 3 for multi entry lz4 compression on df snapshot and single entry on rdb snapshot"); -// Flip this value to 'true' in March 2026. -ABSL_FLAG(bool, rdb_sbf_chunked, false, "Enable new save format for saving SBFs in chunks."); +ABSL_FLAG(bool, rdb_sbf_chunked, true, "Enable new save format for saving SBFs in chunks."); namespace dfly { diff --git a/src/server/rdb_test.cc b/src/server/rdb_test.cc index 9e22fa50dea7..9c4b3c249dd9 100644 --- a/src/server/rdb_test.cc +++ b/src/server/rdb_test.cc @@ -716,7 +716,6 @@ TEST_F(RdbTest, SBF) { } TEST_F(RdbTest, SBFLargeFilterChunking) { - absl::SetFlag(&FLAGS_rdb_sbf_chunked, true); max_memory_limit = 200000000; // Using this set of parameters for the BF.RESERVE command resulted in a diff --git a/tests/dragonfly/replication_test.py b/tests/dragonfly/replication_test.py index d4ff02072230..cbbd6fa45f6f 100644 --- a/tests/dragonfly/replication_test.py +++ b/tests/dragonfly/replication_test.py @@ -4239,7 +4239,6 @@ async def test_sbf_chunked_replication(df_factory: DflyInstanceFactory): master = df_factory.create( proactor_threads=1, maxmemory="6G", - rdb_sbf_chunked="true", ) replica = df_factory.create( proactor_threads=1, @@ -4270,7 +4269,6 @@ async def test_sbf_chunked_replication_chunk_size(df_factory: DflyInstanceFactor master = df_factory.create( proactor_threads=1, maxmemory="4G", - rdb_sbf_chunked="true", ) replica = df_factory.create( proactor_threads=1, From 3dab45f37a101c88b80d54d820b7ec433d054267 Mon Sep 17 00:00:00 2001 From: Roman Gershman Date: Mon, 1 Jun 2026 14:06:19 +0300 Subject: [PATCH 2/2] chore: add "never push to main" rule to CLAUDE.md --- AGENTS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/AGENTS.md b/AGENTS.md index 66f7c7b08438..76c34211b780 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -35,6 +35,7 @@ `ninja && ./unit_test` 4. ✅ **Format Code** - `pre-commit run --files ` 5. ✅ **Follow Architecture** - See [Architecture Patterns](#architecture-patterns) below +6. ✅ **Never Push to Main** - Always create a feature branch and open a PR. Never run `git push origin main`. ### Pull Request Guidelines