From a4306a0dc081c0da00621e611744f6d051e35f06 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 20 Apr 2026 17:13:02 +0000 Subject: [PATCH] fix: skip Firebase Admin auth on image routes when adminAuth is not configured Agent-Logs-Url: https://github.com/driver727-pixel/Punch-Skater/sessions/a38ed908-ed7e-419b-b395-4a78b83df3ee Co-authored-by: driver727-pixel <269849721+driver727-pixel@users.noreply.github.com> --- server/index.js | 1 + server/routes/images.js | 9 +++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/server/index.js b/server/index.js index 63174395..5c0c9f6a 100644 --- a/server/index.js +++ b/server/index.js @@ -688,6 +688,7 @@ registerImageRoutes(app, { fal, FAL_KEY, BIREFNET_URL, + adminAuth, imageRateLimit, boardImageStatusRateLimit, authenticateFirebaseUser, diff --git a/server/routes/images.js b/server/routes/images.js index c5eb9f12..ca94fdfe 100644 --- a/server/routes/images.js +++ b/server/routes/images.js @@ -20,6 +20,7 @@ export function registerImageRoutes(app, { fal, FAL_KEY, BIREFNET_URL, + adminAuth, imageRateLimit, boardImageStatusRateLimit, authenticateFirebaseUser, @@ -39,7 +40,7 @@ export function registerImageRoutes(app, { return; } - await authenticateFirebaseUser(req); + if (adminAuth) await authenticateFirebaseUser(req); const sanitizedBody = sanitizeGenerateImageBody(req.body); const profileSettings = resolveFalProfile(normalizeFalProfile(sanitizedBody.fal_profile)); const upstream = await fetch(profileSettings.modelUrl, { @@ -74,7 +75,7 @@ export function registerImageRoutes(app, { return; } - const caller = await authenticateFirebaseUser(req); + const caller = adminAuth ? await authenticateFirebaseUser(req) : { uid: 'anonymous' }; const { prompt, imageUrls } = sanitizeBoardImageBody(req.body); if (!prompt || !imageUrls) { res.status(400).json({ error: 'A prompt and exactly four Punch Skater board image URLs are required.' }); @@ -109,7 +110,7 @@ export function registerImageRoutes(app, { return; } - const caller = await authenticateFirebaseUser(req); + const caller = adminAuth ? await authenticateFirebaseUser(req) : { uid: 'anonymous' }; const { jobId } = req.params; if (!jobId || !/^[a-zA-Z0-9_-]+$/.test(jobId)) { res.status(400).json({ error: 'Invalid jobId.' }); @@ -160,7 +161,7 @@ export function registerImageRoutes(app, { return; } - await authenticateFirebaseUser(req); + if (adminAuth) await authenticateFirebaseUser(req); const sanitizedBody = sanitizeBackgroundRemovalBody(req.body); const upstream = await fetch(BIREFNET_URL, { method: 'POST',