Skip to content

chore(ai-workflows): concurrency + job-permissions for reusable workflows #231

@JacobPEvans-personal

Description

@JacobPEvans-personal

Context

A workflow audit (run 2026-05-22) surfaced hygiene gaps in this repo's reusable AI workflows that downstream repos inherit.

Findings

CRITICAL — Missing concurrency groups

  • .github/workflows/release-please.yml — publishes releases, no concurrency guard
  • .github/workflows/update-version-tags.yml — pushes tags, no concurrency guard

WARNING — Missing job-level permissions in write jobs

  • .github/workflows/post-merge-tests.yml — runs git push but doesn't declare permissions: contents: write at the job level
  • .github/workflows/_ai-merge-gate.yml — uses gh pr review without declaring pull-requests: write at job level

Action

  1. Add concurrency groups to release-please and update-version-tags workflows
  2. Narrow job-level permissions in workflows that perform writes (don't rely on workflow-level inheritance)
  3. Audit other reusable workflows in .github/workflows/_*.yml for the same patterns

References

  • agentsmd/rules/git-signing.md — App-token pattern, signed commits via Contents API
  • agentsmd/rules/ci-cd-policy.md

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:choreChore - Maintenance tasks, dependencies, tooling

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions