chore: add pre-commit checks and shell formatting

Author: dtsong

.pre-commit-config.yaml

@@ -0,0 +1,32 @@
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v5.0.0
+    hooks:
+      - id: check-merge-conflict
+      - id: check-json
+      - id: check-yaml
+      - id: end-of-file-fixer
+      - id: trailing-whitespace
+        args: [--markdown-linebreak-ext=md]
+      - id: check-added-large-files
+
+  - repo: https://github.com/scop/pre-commit-shfmt
+    rev: v3.11.0-1
+    hooks:
+      - id: shfmt
+        args: [-w, -i, "2", -ci]
+        files: ^(install\.sh|scripts/.*\.sh)$
+
+  - repo: https://github.com/shellcheck-py/shellcheck-py
+    rev: v0.11.0.1
+    hooks:
+      - id: shellcheck
+        files: ^(install\.sh|scripts/.*\.sh)$
+
+  - repo: https://github.com/igorshubovych/markdownlint-cli
+    rev: v0.45.0
+    hooks:
+      - id: markdownlint
+        files: \.md$
+        exclude: ^memory/
+        args: [--disable, MD013, MD033, MD041]

CONTRIBUTING.md

@@ -29,3 +29,13 @@ Each agent markdown should define:
 - Explain why the change exists.
 - Include before/after behavior when relevant.
 - Link issues when possible.
+
+## Local Validation
+
+This repo uses `pre-commit` for lightweight quality checks across shell, JSON/YAML, and markdown.
+
+```bash
+python3 -m pip install --user pre-commit
+pre-commit install
+pre-commit run --all-files
+```

install.sh

@@ -48,7 +48,7 @@ require_registry() {
 assert_profile_exists() {
   local profile_id="$1"
   require_registry
-  if ! python3 - "$REGISTRY_PATH" "$profile_id" <<'PY'
+  if ! python3 - "$REGISTRY_PATH" "$profile_id" <<'PY'; then
 import json
 import sys
 
@@ -57,7 +57,6 @@ registry = json.load(open(registry_path, "r", encoding="utf-8"))
 ids = {p["id"] for p in registry.get("profiles", [])}
 raise SystemExit(0 if profile_id in ids else 1)
 PY
-  then
     echo "Unknown profile: $profile_id"
     echo "Use --list-profiles to view valid profile IDs."
     exit 1
@@ -277,7 +276,8 @@ disable_profile() {
   current_csv="$(load_enabled_profiles)"
 
   local updated_csv
-  updated_csv="$(python3 - "$current_csv" "$profile_id" <<'PY'
+  updated_csv="$(
+    python3 - "$current_csv" "$profile_id" <<'PY'
 import sys
 
 current_csv, profile_id = sys.argv[1], sys.argv[2]
@@ -287,7 +287,7 @@ if not filtered:
     filtered = ["core"]
 print(",".join(filtered))
 PY
-)"
+  )"
 
   install_with_csv "$updated_csv"
 }
@@ -324,7 +324,7 @@ uninstall_all() {
 
 main() {
   case "${1:-}" in
-    "" )
+    "")
       install_with_csv "$(load_enabled_profiles)"
       ;;
     --list-profiles)
@@ -360,7 +360,7 @@ main() {
     --uninstall)
       uninstall_all
       ;;
-    -h|--help)
+    -h | --help)
       usage
       ;;
     *)

scripts/council-lite.sh

@@ -101,7 +101,7 @@ cmd_start() {
 
   mkdir -p "$outdir"
 
-  cat > "$outfile" <<EOF
+  cat >"$outfile" <<EOF
 # Council Lite Session - $stamp
 
 ## Goal
@@ -132,7 +132,7 @@ EOF
 main() {
   local command="${1:-}"
   case "$command" in
-    ""|"-h"|"--help")
+    "" | "-h" | "--help")
       usage
       ;;
     status)

scripts/git-porcelain.sh

@@ -4,7 +4,7 @@ set -euo pipefail
 WORKSPACE="$(git rev-parse --show-toplevel 2>/dev/null || pwd)"
 
 usage() {
-  cat << 'EOF'
+  cat <<'EOF'
 Usage: git-porcelain.sh <command> [args]
 
 Commands:
@@ -37,7 +37,7 @@ EOF
 is_sensitive_path() {
   local path="$1"
   case "$path" in
-    *.pem|*.key|*.p12|*.pfx|*.kube/config|*.env|*.env.*|*credentials*.json|*secrets*.json)
+    *.pem | *.key | *.p12 | *.pfx | *.kube/config | *.env | *.env.* | *credentials*.json | *secrets*.json)
       return 0
       ;;
     *)
@@ -127,20 +127,21 @@ cmd_pr_draft() {
     --head "$branch" \
     --draft \
     --title "$title" \
-    --body "$(cat <<'EOF'
+    --body "$(
+      cat <<'EOF'
 ## Summary
 - Describe the intent and context.
 
 ## Testing
 - [ ] Add the validation commands you ran.
 EOF
-)"
+    )"
 }
 
 main() {
   local command="${1:-}"
   case "$command" in
-    ""|"-h"|"--help")
+    "" | "-h" | "--help")
       usage
       ;;
     status)

scripts/handover.sh

@@ -7,7 +7,7 @@ STAMP="$(date +%Y-%m-%d-%H%M)"
 OUTFILE="$OUTDIR/HANDOVER-$STAMP.md"
 
 if [[ "${1:-}" == "--help" ]]; then
-  cat << 'EOF'
+  cat <<'EOF'
 Usage: handover.sh [--print]
 
 Creates a handover markdown file in memory/ with a repository snapshot.
@@ -32,7 +32,7 @@ if [[ -z "$COMMITS" ]]; then
   COMMITS="(no commits yet)"
 fi
 
-cat > "$OUTFILE" << EOF
+cat >"$OUTFILE" <<EOF
 # Session Handover - $STAMP
 
 ## Workspace Snapshot

scripts/issue-pr-loop.sh

@@ -4,7 +4,7 @@ set -euo pipefail
 WORKSPACE="$(git rev-parse --show-toplevel 2>/dev/null || pwd)"
 
 usage() {
-  cat << 'EOF'
+  cat <<'EOF'
 Usage: issue-pr-loop.sh <command> [args]
 
 Commands:
@@ -29,7 +29,7 @@ require_gh() {
 }
 
 slugify() {
-  python3 - << 'PY'
+  python3 - <<'PY'
 import re
 import sys
 text = sys.stdin.read().strip().lower()
@@ -76,7 +76,8 @@ cmd_pr() {
     --head "$branch" \
     --draft \
     --title "${issue_title}" \
-    --body "$(cat <<EOF
+    --body "$(
+      cat <<EOF
 Closes #$issue
 
 ## Summary
@@ -85,13 +86,13 @@ Closes #$issue
 ## Testing
 - [ ] Add commands run locally
 EOF
-)"
+    )"
 }
 
 main() {
   local command="${1:-}"
   case "$command" in
-    ""|"-h"|"--help")
+    "" | "-h" | "--help")
       usage
       ;;
     start)

scripts/ops-check.sh

@@ -5,7 +5,7 @@ WORKSPACE="$(git rev-parse --show-toplevel 2>/dev/null || pwd)"
 FAILURES=0
 
 usage() {
-  cat << 'EOF'
+  cat <<'EOF'
 Usage: ops-check.sh [--strict]
 
 Runs stack-aware quality checks for Node.js, Python, and Terraform when detected.
@@ -60,7 +60,7 @@ has_tool() {
 
 node_has_script() {
   local key="$1"
-  python3 - << PY
+  python3 - <<PY
 import json
 from pathlib import Path
 pkg = Path("$WORKSPACE/package.json")
@@ -144,7 +144,7 @@ check_python() {
 }
 
 check_terraform() {
-  if ! compgen -G "$WORKSPACE/*.tf" > /dev/null; then
+  if ! compgen -G "$WORKSPACE/*.tf" >/dev/null; then
     return
   fi