Skip to content

Commit d246d69

Browse files
committed
Remove commented out code
Retrait du code commented out + ajustement de docstrings + linting
1 parent 3bf7221 commit d246d69

2 files changed

Lines changed: 13 additions & 17 deletions

File tree

pyhilo/devices.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -110,18 +110,6 @@ async def update(self) -> None:
110110
if dev not in self.devices:
111111
self.devices.append(dev)
112112

113-
# Append gateway from REST API (still available)
114-
# try:
115-
# gw = await self._api.get_gateway(self.location_id)
116-
# LOG.debug("Generating gateway device %s", gw)
117-
# gw_dev = self.generate_device(gw)
118-
# generated_devices.append(gw_dev)
119-
# if gw_dev not in self.devices:
120-
# self.devices.append(gw_dev)
121-
# except Exception as err:
122-
# LOG.error("Failed to get gateway: %s", err)
123-
124-
# Now add devices from external sources (e.g. unknown source tracker)
125113
for callback in self._api._get_device_callbacks:
126114
try:
127115
cb_device = callback()

pyhilo/graphql.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -590,9 +590,16 @@ async def call_get_location_query(self, location_hilo_id: str) -> None:
590590
return
591591

592592
if "data" in response_json:
593-
devices = response_json["data"].get("getLocation", {}).get("devices", [])
594-
gateways = [d for d in devices if d.get("deviceType") in ("Gateway", "Hub")]
595-
LOG.debug("Gateway devices in getLocation response: %s", json.dumps(gateways, indent=2))
593+
devices = (
594+
response_json["data"].get("getLocation", {}).get("devices", [])
595+
)
596+
gateways = [
597+
d for d in devices if d.get("deviceType") in ("Gateway", "Hub")
598+
]
599+
LOG.debug(
600+
"Gateway devices in getLocation response: %s",
601+
json.dumps(gateways, indent=2),
602+
)
596603
self._handle_query_result(response_json["data"])
597604

598605
async def subscribe_to_device_updated(
@@ -828,15 +835,16 @@ def _build_gateway_dict(self, raw_device: Dict[str, Any]) -> Dict[str, Any]:
828835
"supportedAttributes": "zigBeePairingActivated, zigBeeChannel, firmwareVersion, onlineStatus, lastStatusTime, disconnected",
829836
"settableAttributes": "",
830837
"Disconnected": {"value": connection_status != "CONNECTED"},
831-
"zigBeePairingActivated": {"value": bool(raw_device.get("zigBeePairingModeEnhanced"))},
838+
"zigBeePairingActivated": {
839+
"value": bool(raw_device.get("zigBeePairingModeEnhanced"))
840+
},
832841
"zigBeeChannel": {"value": raw_device.get("zigBeeChannel")},
833842
"firmwareVersion": {"value": raw_device.get("controllerSoftwareVersion")},
834843
"onlineStatus": {"value": connection_status},
835844
"lastStatusTime": {"value": raw_device.get("lastConnectionTime")},
836845
"disconnected": {"value": connection_status != "CONNECTED"},
837846
}
838847

839-
840848
def _handle_device_subscription_result(self, result: Dict[str, Any]) -> str:
841849
device_value: Dict[str, Any] = result["onAnyDeviceUpdated"]["device"]
842850
attributes = self.mapper.map_device_subscription_values(device_value)

0 commit comments

Comments
 (0)