should validate the build against lightning_dxpr_project

[hoatle]

jurriaan 11:08 PM
@hoat Le we recently had a failure of lightning_dxpr_project builds because we made a little mistake on the composer.json of its child-repo: https://github.com/dxpr/lightning_dxpr
is is possible you copy the PR tests with have on lightning_dxpr_project to lightning_dxpr so that we can validate our build against composer 1.x and 2.x?

Hoat Le 22 hours ago
I could add a trigger to validate lightning_dxpr_project (2.x) when there is new commit from lightning_dxpr (2.x), is that ok @jurriaan? (edited)

Hoat Le 22 hours ago
do you want to validate lightning_dxpr_project against the https://github.com/dxpr/lightning_dxpr 1.x branch?
🔴
1

jurriaan 22 hours ago
@hoat Le ok, so I rely on an email to be notified of the triggered check? or will it show somewhere in github UI?

jurriaan 22 hours ago
the lightning_dxpr 1.x branch is not used anymore, the 2.x branch is

jurriaan 22 hours ago
you can skip the 1.x branch

Hoat Le 21 hours ago
the trigger is automatic

[jjroelofs]

@hoatle I have a PR here, do you think it worked OK? https://github.com/dxpr/lightning_dxpr/pull/20/checks

[hoatle]

@jjroelofs the checks were passed so I don't think there could be any problem with composer install https://github.com/dxpr/lightning_dxpr_project/actions