Skip to content

[23355] Remove deprecated windows-2019 runner#148

Merged
rsanchez15 merged 1 commit into
mainfrom
feature/remove-windows-2019
Jun 27, 2025
Merged

[23355] Remove deprecated windows-2019 runner#148
rsanchez15 merged 1 commit into
mainfrom
feature/remove-windows-2019

Conversation

@rsanchez15

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.94%. Comparing base (3e459df) to head (16af28e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   36.49%   37.94%   +1.45%     
==========================================
  Files         170      153      -17     
  Lines       11657     6984    -4673     
  Branches     5327     2777    -2550     
==========================================
- Hits         4254     2650    -1604     
+ Misses       4645     2941    -1704     
+ Partials     2758     1393    -1365     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mario-DL Mario-DL left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the PLATFORM_SUPPORT we have MSVC v141 (Visual Studio 2017) but as tier 3 which I think it is just fine

@rsanchez15

Copy link
Copy Markdown
Contributor Author

In the PLATFORM_SUPPORT we have MSVC v141 (Visual Studio 2017) but as tier 3 which I think it is just fine

Yes, that's fine

@rsanchez15 rsanchez15 merged commit d0008a6 into main Jun 27, 2025
15 checks passed
@rsanchez15 rsanchez15 deleted the feature/remove-windows-2019 branch June 27, 2025 07:20
@rsanchez15

Copy link
Copy Markdown
Contributor Author

@Mergifyio backport 0.x

@mergify

mergify Bot commented Jun 27, 2025

Copy link
Copy Markdown

backport 0.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Jun 27, 2025
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit d0008a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants