Split RTPS and DDS Listeners in DynTypesParticipant#157
Merged
Conversation
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
juanlofer-eprosima
requested changes
Jul 17, 2025
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
cferreiragonz
force-pushed
the
fix_dual_listener
branch
from
f196dfa to
558bf48
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.x #157 +/- ##
======================================
Coverage ? 34.12%
======================================
Files ? 154
Lines ? 7901
Branches ? 3518
======================================
Hits ? 2696
Misses ? 3281
Partials ? 1924 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the Listener of DynTypesParticipant into two separated listeners: RTPS and DDS.
In this way, the logic of each listener is isolated from the other.
Also, it allows the SpyDdsParticipant to store in the DDS listener the GUID of the RTPS listener as it will already be created during the DDS participant construction. This allows to properly filter out any discovery message received from the RTPS listener.
This PR is necessary to implement: