From 8370e3c2dfbae84f4c3b74519b24612a863e9405 Mon Sep 17 00:00:00 2001 From: Raul Sanchez-Mateos Date: Tue, 27 May 2025 07:36:35 +0200 Subject: [PATCH 1/5] Test new version of test reporter Signed-off-by: Raul Sanchez-Mateos --- .github/workflows/reusable-ubuntu-ci.yml | 6 +++--- .github/workflows/reusable-workflow.yml | 4 ++-- ddsrouter_core/test/unittest/ParticipantFactoryTest.cpp | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/reusable-ubuntu-ci.yml b/.github/workflows/reusable-ubuntu-ci.yml index 9a226c446..b214bad85 100644 --- a/.github/workflows/reusable-ubuntu-ci.yml +++ b/.github/workflows/reusable-ubuntu-ci.yml @@ -126,7 +126,7 @@ jobs: - name: Test Report - uses: eProsima/eProsima-CI/external/test-reporter@v0 + uses: eProsima/eProsima-CI/external/test-reporter@feature/upgrade-test-reporter if: success() || failure() with: name: "Report: ASAN " @@ -173,7 +173,7 @@ jobs: test_report_artifact: test_report_tsan${{ inputs.dependencies_artifact_postfix }}_${{ inputs.custom_version_build }} - name: Test Report - uses: eProsima/eProsima-CI/external/test-reporter@v0 + uses: eProsima/eProsima-CI/external/test-reporter@feature/upgrade-test-reporter if: success() || failure() with: name: "Report: TSAN " @@ -277,7 +277,7 @@ jobs: test_report_artifact: test_report_flaky${{ inputs.dependencies_artifact_postfix }}_${{ inputs.custom_version_build }} - name: Test Report - uses: eProsima/eProsima-CI/external/test-reporter@v0 + uses: eProsima/eProsima-CI/external/test-reporter@feature/upgrade-test-reporter if: success() || failure() with: name: "Report: Flaky " diff --git a/.github/workflows/reusable-workflow.yml b/.github/workflows/reusable-workflow.yml index 605caaf40..f4e53e785 100644 --- a/.github/workflows/reusable-workflow.yml +++ b/.github/workflows/reusable-workflow.yml @@ -76,7 +76,7 @@ jobs: - name: Compile and run tests id: compile_and_test - uses: eProsima/eProsima-CI/multiplatform/colcon_build_test@main + uses: eProsima/eProsima-CI/multiplatform/colcon_build_test@v0 with: packages_names: ${{ env.code_packages_names }} cmake_args: -DBUILD_TESTS=ON -DCMAKE_BUILD_TYPE=${{ matrix.cmake_build_type }} @@ -87,7 +87,7 @@ jobs: - name: Test Report - uses: eProsima/eProsima-CI/external/test-reporter@main + uses: eProsima/eProsima-CI/external/test-reporter@feature/upgrade-test-reporter if: success() || failure() with: name: "Report: ${{ inputs.os }} | ${{ matrix.cmake_build_type }} " diff --git a/ddsrouter_core/test/unittest/ParticipantFactoryTest.cpp b/ddsrouter_core/test/unittest/ParticipantFactoryTest.cpp index 0b421c9d5..895f39d5d 100644 --- a/ddsrouter_core/test/unittest/ParticipantFactoryTest.cpp +++ b/ddsrouter_core/test/unittest/ParticipantFactoryTest.cpp @@ -128,7 +128,7 @@ TEST(ParticipantFactoryTest, create_echo_participant) ASSERT_TRUE(echo_participant) << "Failed to create Echo Participant"; - ASSERT_EQ(echo_participant->configuration_->app_id, "DDS_ROUTER"); + ASSERT_EQ(echo_participant->configuration_->app_id, "DDS_ROUTER_FAIL"); ASSERT_EQ(echo_participant->configuration_->app_metadata, ""); } } From 00c678a347355d51166cb66fa9c70c2857d1b1f0 Mon Sep 17 00:00:00 2001 From: Raul Sanchez-Mateos Date: Thu, 26 Jun 2025 09:17:39 +0200 Subject: [PATCH 2/5] Add workflow dispatch to nightly CIs Signed-off-by: Raul Sanchez-Mateos --- .github/workflows/nightly-system-ci.yml | 1 + .github/workflows/nightly-ubuntu-ci.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/nightly-system-ci.yml b/.github/workflows/nightly-system-ci.yml index a2d78390c..ae5a3b4c6 100644 --- a/.github/workflows/nightly-system-ci.yml +++ b/.github/workflows/nightly-system-ci.yml @@ -2,6 +2,7 @@ name: nightly-system-ci on: + workflow_dispatch: schedule: - cron: '0 5 * * *' diff --git a/.github/workflows/nightly-ubuntu-ci.yml b/.github/workflows/nightly-ubuntu-ci.yml index ca7d5525b..c2688a967 100644 --- a/.github/workflows/nightly-ubuntu-ci.yml +++ b/.github/workflows/nightly-ubuntu-ci.yml @@ -2,6 +2,7 @@ name: nightly-ubuntu-ci on: + workflow_dispatch: schedule: - cron: '0 5 * * *' From 6616985bfff84fe818ae08341e9ef841becbf717 Mon Sep 17 00:00:00 2001 From: Raul Sanchez-Mateos Date: Thu, 26 Jun 2025 09:26:05 +0200 Subject: [PATCH 3/5] (tmp) Remove some tests Signed-off-by: Raul Sanchez-Mateos --- .github/workflows/test.yml | 42 +++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a28d259a3..491571e9f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -68,25 +68,25 @@ jobs: ref: ${{ github.ref }} secrets: inherit - reusable_tests_windows: - name: reusable_tests - uses: ./.github/workflows/reusable-windows-ci.yml - with: - custom_version_build: ${{ inputs.custom_version_build || 'v3' }} - dependencies_artifact_postfix: ${{ inputs.dependencies_artifact_postfix || '_nightly' }} - ref: ${{ github.ref }} - secrets: inherit + # reusable_tests_windows: + # name: reusable_tests + # uses: ./.github/workflows/reusable-windows-ci.yml + # with: + # custom_version_build: ${{ inputs.custom_version_build || 'v3' }} + # dependencies_artifact_postfix: ${{ inputs.dependencies_artifact_postfix || '_nightly' }} + # ref: ${{ github.ref }} + # secrets: inherit - reusable_docker_tests: - name: reusable_docker_tests - uses: ./.github/workflows/docker-reusable-workflow.yml - with: - fastcdr_branch: ${{ inputs.fastcdr_branch || '2.x' }} - fastdds_branch: ${{ inputs.fastdds_branch || '3.x' }} - devutils_branch: ${{ inputs.devutils_branch || '1.x' }} - ddspipe_branch: ${{ inputs.ddspipe_branch || '1.x' }} - ddsrouter_branch: ${{ inputs.ddsrouter_branch || github.head_ref || github.ref_name }} - custom_version_build: ${{ inputs.custom_version_build || 'v3' }} - dependencies_artifact_postfix: ${{ inputs.dependencies_artifact_postfix || '_nightly' }} - ref: ${{ github.ref }} - secrets: inherit + # reusable_docker_tests: + # name: reusable_docker_tests + # uses: ./.github/workflows/docker-reusable-workflow.yml + # with: + # fastcdr_branch: ${{ inputs.fastcdr_branch || '2.x' }} + # fastdds_branch: ${{ inputs.fastdds_branch || '3.x' }} + # devutils_branch: ${{ inputs.devutils_branch || '1.x' }} + # ddspipe_branch: ${{ inputs.ddspipe_branch || '1.x' }} + # ddsrouter_branch: ${{ inputs.ddsrouter_branch || github.head_ref || github.ref_name }} + # custom_version_build: ${{ inputs.custom_version_build || 'v3' }} + # dependencies_artifact_postfix: ${{ inputs.dependencies_artifact_postfix || '_nightly' }} + # ref: ${{ github.ref }} + # secrets: inherit From 5ad942b4997c4ac189ea8bc20799f4c474901e94 Mon Sep 17 00:00:00 2001 From: Raul Sanchez-Mateos Date: Thu, 26 Jun 2025 10:18:57 +0200 Subject: [PATCH 4/5] Hide passed suites Signed-off-by: Raul Sanchez-Mateos --- .github/workflows/nightly-windows-ci.yml | 1 + .github/workflows/reusable-ubuntu-ci.yml | 3 ++ .github/workflows/reusable-workflow.yml | 1 + .github/workflows/test.yml | 42 ++++++++++++------------ 4 files changed, 26 insertions(+), 21 deletions(-) diff --git a/.github/workflows/nightly-windows-ci.yml b/.github/workflows/nightly-windows-ci.yml index f0a9ce100..27c706327 100644 --- a/.github/workflows/nightly-windows-ci.yml +++ b/.github/workflows/nightly-windows-ci.yml @@ -2,6 +2,7 @@ name: nightly-windows-ci on: + workflow_dispatch: schedule: - cron: '0 5 * * *' diff --git a/.github/workflows/reusable-ubuntu-ci.yml b/.github/workflows/reusable-ubuntu-ci.yml index b214bad85..5c8936c28 100644 --- a/.github/workflows/reusable-ubuntu-ci.yml +++ b/.github/workflows/reusable-ubuntu-ci.yml @@ -133,6 +133,7 @@ jobs: path: "${{ steps.compile_and_test.outputs.ctest_results_path }}*.xml" working-directory: 'src' list-tests: 'failed' + list-suites: 'failed' ##################################################################### # TSAN @@ -180,6 +181,7 @@ jobs: path: "${{ steps.compile_and_test.outputs.ctest_results_path }}*.xml" working-directory: 'src' list-tests: 'failed' + list-suites: 'failed' ##################################################################### # CLANG @@ -285,6 +287,7 @@ jobs: working-directory: 'src' fail-on-empty: 'false' list-tests: 'failed' + list-suites: 'failed' ##################################################################### # DOCUMENTATION TEST diff --git a/.github/workflows/reusable-workflow.yml b/.github/workflows/reusable-workflow.yml index f4e53e785..b5158ceae 100644 --- a/.github/workflows/reusable-workflow.yml +++ b/.github/workflows/reusable-workflow.yml @@ -95,3 +95,4 @@ jobs: working-directory: 'src' path-replace-backslashes: 'true' list-tests: 'failed' + list-suites: 'failed' diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 491571e9f..a28d259a3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -68,25 +68,25 @@ jobs: ref: ${{ github.ref }} secrets: inherit - # reusable_tests_windows: - # name: reusable_tests - # uses: ./.github/workflows/reusable-windows-ci.yml - # with: - # custom_version_build: ${{ inputs.custom_version_build || 'v3' }} - # dependencies_artifact_postfix: ${{ inputs.dependencies_artifact_postfix || '_nightly' }} - # ref: ${{ github.ref }} - # secrets: inherit + reusable_tests_windows: + name: reusable_tests + uses: ./.github/workflows/reusable-windows-ci.yml + with: + custom_version_build: ${{ inputs.custom_version_build || 'v3' }} + dependencies_artifact_postfix: ${{ inputs.dependencies_artifact_postfix || '_nightly' }} + ref: ${{ github.ref }} + secrets: inherit - # reusable_docker_tests: - # name: reusable_docker_tests - # uses: ./.github/workflows/docker-reusable-workflow.yml - # with: - # fastcdr_branch: ${{ inputs.fastcdr_branch || '2.x' }} - # fastdds_branch: ${{ inputs.fastdds_branch || '3.x' }} - # devutils_branch: ${{ inputs.devutils_branch || '1.x' }} - # ddspipe_branch: ${{ inputs.ddspipe_branch || '1.x' }} - # ddsrouter_branch: ${{ inputs.ddsrouter_branch || github.head_ref || github.ref_name }} - # custom_version_build: ${{ inputs.custom_version_build || 'v3' }} - # dependencies_artifact_postfix: ${{ inputs.dependencies_artifact_postfix || '_nightly' }} - # ref: ${{ github.ref }} - # secrets: inherit + reusable_docker_tests: + name: reusable_docker_tests + uses: ./.github/workflows/docker-reusable-workflow.yml + with: + fastcdr_branch: ${{ inputs.fastcdr_branch || '2.x' }} + fastdds_branch: ${{ inputs.fastdds_branch || '3.x' }} + devutils_branch: ${{ inputs.devutils_branch || '1.x' }} + ddspipe_branch: ${{ inputs.ddspipe_branch || '1.x' }} + ddsrouter_branch: ${{ inputs.ddsrouter_branch || github.head_ref || github.ref_name }} + custom_version_build: ${{ inputs.custom_version_build || 'v3' }} + dependencies_artifact_postfix: ${{ inputs.dependencies_artifact_postfix || '_nightly' }} + ref: ${{ github.ref }} + secrets: inherit From 7513a12c04cb753a983580be76ffee39b1b4f84d Mon Sep 17 00:00:00 2001 From: Raul Sanchez-Mateos Date: Thu, 10 Jul 2025 08:02:06 +0200 Subject: [PATCH 5/5] Restore changes to use eprosima-ci Signed-off-by: Raul Sanchez-Mateos --- .github/workflows/reusable-ubuntu-ci.yml | 6 +++--- .github/workflows/reusable-workflow.yml | 2 +- ddsrouter_core/test/unittest/ParticipantFactoryTest.cpp | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/reusable-ubuntu-ci.yml b/.github/workflows/reusable-ubuntu-ci.yml index 5c8936c28..5459f264b 100644 --- a/.github/workflows/reusable-ubuntu-ci.yml +++ b/.github/workflows/reusable-ubuntu-ci.yml @@ -126,7 +126,7 @@ jobs: - name: Test Report - uses: eProsima/eProsima-CI/external/test-reporter@feature/upgrade-test-reporter + uses: eProsima/eProsima-CI/external/test-reporter@v0 if: success() || failure() with: name: "Report: ASAN " @@ -174,7 +174,7 @@ jobs: test_report_artifact: test_report_tsan${{ inputs.dependencies_artifact_postfix }}_${{ inputs.custom_version_build }} - name: Test Report - uses: eProsima/eProsima-CI/external/test-reporter@feature/upgrade-test-reporter + uses: eProsima/eProsima-CI/external/test-reporter@v0 if: success() || failure() with: name: "Report: TSAN " @@ -279,7 +279,7 @@ jobs: test_report_artifact: test_report_flaky${{ inputs.dependencies_artifact_postfix }}_${{ inputs.custom_version_build }} - name: Test Report - uses: eProsima/eProsima-CI/external/test-reporter@feature/upgrade-test-reporter + uses: eProsima/eProsima-CI/external/test-reporter@v0 if: success() || failure() with: name: "Report: Flaky " diff --git a/.github/workflows/reusable-workflow.yml b/.github/workflows/reusable-workflow.yml index b5158ceae..863aa415b 100644 --- a/.github/workflows/reusable-workflow.yml +++ b/.github/workflows/reusable-workflow.yml @@ -87,7 +87,7 @@ jobs: - name: Test Report - uses: eProsima/eProsima-CI/external/test-reporter@feature/upgrade-test-reporter + uses: eProsima/eProsima-CI/external/test-reporter@v0 if: success() || failure() with: name: "Report: ${{ inputs.os }} | ${{ matrix.cmake_build_type }} " diff --git a/ddsrouter_core/test/unittest/ParticipantFactoryTest.cpp b/ddsrouter_core/test/unittest/ParticipantFactoryTest.cpp index 895f39d5d..0b421c9d5 100644 --- a/ddsrouter_core/test/unittest/ParticipantFactoryTest.cpp +++ b/ddsrouter_core/test/unittest/ParticipantFactoryTest.cpp @@ -128,7 +128,7 @@ TEST(ParticipantFactoryTest, create_echo_participant) ASSERT_TRUE(echo_participant) << "Failed to create Echo Participant"; - ASSERT_EQ(echo_participant->configuration_->app_id, "DDS_ROUTER_FAIL"); + ASSERT_EQ(echo_participant->configuration_->app_id, "DDS_ROUTER"); ASSERT_EQ(echo_participant->configuration_->app_metadata, ""); } }