[21670] Update Spy Listeners#121
Merged
Merged
Conversation
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
cferreiragonz
force-pushed
the
update_listeners
branch
from
2832d11 to
46f8794
Compare
Contributor
Author
|
CI with proper DDS Pipe branch here. |
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
juanlofer-eprosima
requested changes
Jul 10, 2025
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
juanlofer-eprosima
previously approved these changes
Jul 14, 2025
juanlofer-eprosima
left a comment
juanlofer-eprosima
left a comment
Contributor
There was a problem hiding this comment.
LGTM with greenish CI.
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Contributor
Author
|
CI passed on #123 |
Contributor
Author
|
@Mergifyio backport 0.x |
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Update Spy Listeners Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply review Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply last pipe changes Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Fix type_object_reader Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 6a01d7d) # Conflicts: # fastddsspy_participants/include/fastddsspy_participants/participant/SpyDdsParticipant.hpp # fastddsspy_participants/src/cpp/participant/SpyDdsParticipant.cpp
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Jul 17, 2025
* Update Spy Listeners (#121) * Update Spy Listeners Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply review Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply last pipe changes Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Fix type_object_reader Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 6a01d7d) # Conflicts: # fastddsspy_participants/include/fastddsspy_participants/participant/SpyDdsParticipant.hpp # fastddsspy_participants/src/cpp/participant/SpyDdsParticipant.cpp * Solve conflicts Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Remove windows 2019 workflow Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply changes of dual listeners in DDS pipe Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply review Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Fix bug shadow parameter Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes all the necessary changes in order to compile Fast DDS Spy after the modifications introduced in:
And must me merged after it.