[21670] Update Spy Listeners (backport #121)#125
Merged
Conversation
* Update Spy Listeners Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply review Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply last pipe changes Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Fix type_object_reader Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 6a01d7d) # Conflicts: # fastddsspy_participants/include/fastddsspy_participants/participant/SpyDdsParticipant.hpp # fastddsspy_participants/src/cpp/participant/SpyDdsParticipant.cpp
Author
|
Cherry-pick of 6a01d7d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Contributor
|
This PR must be merged after: |
juanlofer-eprosima
requested changes
Jul 17, 2025
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.x #125 +/- ##
======================================
Coverage ? 64.02%
======================================
Files ? 24
Lines ? 1162
Branches ? 419
======================================
Hits ? 744
Misses ? 150
Partials ? 268 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
juanlofer-eprosima
approved these changes
Jul 17, 2025
juanlofer-eprosima
left a comment
Contributor
There was a problem hiding this comment.
LGTM, well done buddy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes all the necessary changes in order to compile Fast DDS Spy after the modifications introduced in:
And must me merged after them.
This is an automatic backport of pull request #121 done by Mergify.