Skip to content

[21670] Update Spy Listeners (backport #121)#125

Merged
juanlofer-eprosima merged 6 commits into
0.xfrom
mergify/bp/0.x/pr-121
Jul 17, 2025
Merged

[21670] Update Spy Listeners (backport #121)#125
juanlofer-eprosima merged 6 commits into
0.xfrom
mergify/bp/0.x/pr-121

Conversation

@mergify

@mergify mergify Bot commented Jul 16, 2025

Copy link
Copy Markdown

This PR includes all the necessary changes in order to compile Fast DDS Spy after the modifications introduced in:

And must me merged after them.


This is an automatic backport of pull request #121 done by Mergify.

* Update Spy Listeners

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Uncrustify

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Apply review

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Apply last pipe changes

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Fix type_object_reader

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 6a01d7d)

# Conflicts:
#	fastddsspy_participants/include/fastddsspy_participants/participant/SpyDdsParticipant.hpp
#	fastddsspy_participants/src/cpp/participant/SpyDdsParticipant.cpp
@mergify mergify Bot added the conflicts label Jul 16, 2025
@mergify

mergify Bot commented Jul 16, 2025

Copy link
Copy Markdown
Author

Cherry-pick of 6a01d7d has failed:

On branch mergify/bp/0.x/pr-121
Your branch is up to date with 'origin/0.x'.

You are currently cherry-picking commit 6a01d7d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fastddsspy_participants/include/fastddsspy_participants/participant/SpyDdsParticipant.hpp
	both modified:   fastddsspy_participants/src/cpp/participant/SpyDdsParticipant.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz

Copy link
Copy Markdown
Contributor

This PR must be merged after:

Comment thread fastddsspy_participants/src/cpp/participant/SpyDdsParticipant.cpp
Comment thread fastddsspy_participants/src/cpp/participant/SpyDdsParticipant.cpp
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@codecov

codecov Bot commented Jul 17, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (0.x@b247960). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...icipants/src/cpp/participant/SpyDdsParticipant.cpp 61.53% 3 Missing and 7 partials ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             0.x     #125   +/-   ##
======================================
  Coverage       ?   64.02%           
======================================
  Files          ?       24           
  Lines          ?     1162           
  Branches       ?      419           
======================================
  Hits           ?      744           
  Misses         ?      150           
  Partials       ?      268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juanlofer-eprosima juanlofer-eprosima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done buddy!

@juanlofer-eprosima juanlofer-eprosima merged commit fd42db5 into 0.x Jul 17, 2025
16 of 19 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the mergify/bp/0.x/pr-121 branch July 17, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants