Validierung aller Entities (Vom alten Backend kopieren)

[BacLuc]

I merged the existing Validations/InputFilters with the ones from the old backend and added the once i thought would be helpful.
(Maybe some parts are not up to date, i finished it at commit 05edfbf).
If you have time, grab an entity, copy the validations to a separate issue, add the validations and the tests for it and we are happy to see your PR.

ColumnLayout.php

• JSON Schema von Columns
• Columns müssen zusammen eine breite von 12 haben
• Keine orphan children

MaterialNode.php

Done (Zusätzliche Property von Contentnode kann nicht gepatched werden)

MultiSelect.php

Done (Zusätzliche Property von Contentnode kann nicht gepatched werden)

MultiSelectOption.php

• translate key kann nicht gepatched werden
• MaterialList kann nicht gepatched werden
• checked muss ein boolean sein (done with refactor(api)!: json data for ContentNode (new approach) #2825 )
• options must be null on create ( Api: entity validations 3 #2979)

SingleText.php

• CleanHtml

Storyboard.php

Done (Zusätzliche Property von Contentnode kann nicht gepatched werden)

• Letzte Zeile kann nicht gelöscht werden. fix(api+frontend): ensure storyboard has min. 1 section #2995

StoryboardSection.php

• StoryBoard must not be null (done with refactor(api)!: json data for ContentNode (new approach) #2825 because the Section does not exist anymore)
• column1-3: cleanhtml

AbstractContentNodeOwner.php

Done

Activity.php

Entity

• At least one scheduleEntry must remain, or delete the activity when the last scheduleentry is deleted (else it might be difficult to delete the activity) Api entity validations #2903
  Properties
• When creating an Activity, at least one ScheduleEntry must be present
• Category must not be null
• Camp must not be null
• Title Api entity validations #2903
  • Length >0 and length <= 32
  • no cleanhtml
  • trim
• Location Api entity validations #2903
  • Length >0 (Default is empty string) and length <= 64
  • no cleanhtml
  • trim

ActivityResponsible.php

Done

BaseEntity.php

#2903

• Id is not writable (one tests with a random entity
• createTime is not writable
• updateTime is not writable

Camp.php

Entity

• Camp has at least one manager Campcollaboration: assert at least one manager in camp #2363
• Camp has at least one period Letzte Periode nicht löschbar #1278 Camp: assert at least one period in camp #2406
• periods must not overlap (until Feature: Allow overlapping periods #2454 is implemented)

Properties

• isPrototype not writable (maybe for people with extended privileges)
• name
  • Length >0 and length <= 32
  • no cleanhtml
  • trim
• title
  • Length >0 and length <= 32
  • no cleanhtml
  • trim
• motto
  • length <= 128
  • no cleanhtml
  • trim
• addressName
  • length <= 128
  • no cleanhtml
  • trim
• addressStreet
  • length <= 128
  • no cleanhtml
  • trim
• addressZipcode
  • length <= 128
  • no cleanhtml
  • trim
• addressCity
  • length <= 128
  • no cleanhtml
  • trim

CampCollaboration.php

Entity

• Campcollaboration: assert at least one manager in camp #2363
• CampCollaboration: add unique constraints on (user, camp) and (invite… #2356
• Either user or inviteEmail is set
  Properties
• camp has at least one manager Campcollaboration: assert at least one manager in camp #2363
• inviteEmail Api entity validations #2903
  • valid email
  • length <= 128
• status
  • not null
  • valid status
  • valid transition
• role
  • not null
  • valid role

Category.php

Entity

• Cannot be deleted as long as activities are linked to it (happened in One transaction per request #2536, 9dc67cf)
  Properties
• camp
  • not null
  • cannot be changed
• short (Api entity validations 2 #2919 )
  • length > 0 && length <= 16
  • no cleanhtml (api: fix clean html on Category and MaterialList #3014)
  • trim
• name (Api entity validations 2 #2919 )
  • length >0 && length <= 32
  • no cleanhtml (api: fix clean html on Category and MaterialList #3014)
  • trim
• color
  • valid color
  • not null
• numbering style
  • not null
  • valid numbering style

ContentNode.php

Properties

• Validate that the parent content node supports children (Api: entity validations 3 #2979)
• parent
  • belongs to same owner
  • no loop
  • either is null or root is null, but not both and not both not null
• children
  • Mostly done with the validation of the parent
  • Validate that all children have a supported slot name (Api entity validations 4 #3126)
• position
  • not null
  • guarantee uniqueness of parent+slot+position (Api entity validations 4 #3126 )
• instanceName
  • length >0 && length <= 32 (tests needed) (Api entity validations 4 #3126 )
  • trim (tests needed) (Api entity validations 4 #3126 )
  • CleanText (tests needed) (Api entity validations 4 #3126 )
• contenttype
  • not null
  • content type and content node are compatible

ContentType.php

• Create, update and delete is not possible

Day.php

• Create, update and delete is not possible

DayResponsible.php

** Done **

MaterialItem.php

• materialList belongs to same camp
• period
  • belongs to same camp
  • either is null (period and materialNode)
• materialNode
  • belongs to same camp
  • either is null (period and materialNode)
• article
  • length >0 && length <= 32
  • trim
• quantity
  • float
• unit
  • 0 <= length <= 32
  • trim

MaterialList.php

• camp
  • cannot be changed
• campCollaboration
  • cannot be changed
  • Je nach dem either is null mit name, (TO BE DISCUSSED Follow up to Create materiallist for collaboration #2574)
• name
  • 1 < length <= 32
  • no cleanhtml (api: fix clean html on Category and MaterialList #3014)
  • trim

Period.php

• camp
  • cannot be changed
  • periods must not overlap (until Feature: Allow overlapping periods #2454 is implemented)
• Description (Api entity validations 2 #2919 )
  • length >0 && length <= 32 (In the old backend it was 128)
  • no cleanhtml
  • trim
• start
  • less than or equal to end
  • less than or or equal to earliest schedule entry
  • date (without time and without time zone), test is missing
• end
  • greater than or equal to start
  • greater than or or equal to latest schedule entry
  • date (without time and without time zone), test is missing

Profile.php

• email
  • trim
  • not blank, not null
  • valid email
  • unique
• username
  • trim
  • not blank, not null
  • unique
  • pattern: /^[a-z0-9_.@-]+$/
• firstname
  • length <= 64
  • no cleanhtml
  • trim
• surname
  • length <= 64
  • no cleanhtml
  • trim
• nickname
  • length <= 32
  • no cleanhtml
  • trim
• language
  • valid language
  • trim (Do we need a trim here?)
• user
  • not null (Assured because profile can only be created with nested post over user, and patch user is not allowed)

ScheduleEntry.php

• period
  • cannot be null
  • belongs to same camp as activity
• activity
  • not null
  • belongs to same camp as period
  • cannot be changed
• startOffset
  • must be inside period (wollen wir diese invariant?)
• endOffset
  • must be inside period (wollen wir diese invariant?)
• left
  • 0 <= left < 1 (was für ein minimalwert für die width ist sinnvoll?)
  • left + width = 1
• width
  • 0 < width <= 1
  • left + width = 1
• start
  • >= period.start
• end
  • <= period.end

SortableEntityInterface.php

Validations können hoffentlich in SortableEntityTrait implementiert werden

SortableEntityTrait.php

• position
  • -1 >= position

User.php

• activationKeyHash
  • Is not writeable
• password
  • Is not writeable
• passwordResetKeyHash
  • Is not writeable
• profile
  • not null
  • another profile cannot be referenced, a new profile must be created when creating a user
  • you cannot link to another profile
  • embedded patch is not allowed
  • unique (assured by oneToOne)