Unhandled CoreException

[MartinVon1021]

In Eclipse 4.32 (2024-06) and above, when I open a .class file in the bin directory from the Project Explorer, the attached error file appears.

This is caused by the following code explicitly throwing an exception.
org.sf.feeling.decompiler/src/org/sf/feeling/decompiler/editor/JavaDecompilerClassFileEditor.java
throw new CoreException(new Status(8, JavaDecompilerConstants.PLUGIN_ID, 1, "", null));

log3.txt

[jpstotz]

Thanks for reporting. I im trying to find out why this CoreException is thrown there without any check:

ecd/org.sf.feeling.decompiler/src/org/sf/feeling/decompiler/editor/JavaDecompilerClassFileEditor.java

Lines 375 to 385 in 8cedc53

	Display.getDefault().asyncExec(new Runnable() {
	@Override
	public void run() {
	JavaDecompilerClassFileEditor.this.getEditorSite().getPage()
	.closeEditor(JavaDecompilerClassFileEditor.this, false);
	}
	});
	throw new CoreException(new Status(8, JavaDecompilerConstants.PLUGIN_ID, 1, "", //$NON-NLS-1$
	null));

It looks like this exception is always thrown when the input is of type FileStoreEditorInput. Also the closeEditor code in the asyncExec section right before the exception is thrown looks to me like error handling code, but it is always executed.

This whole code section is pretty old. It was already present in the "initial commit" 5a472fb from 2017

ecd/org.sf.feeling.decompiler/src/org/sf/feeling/decompiler/editor/JavaDecompilerClassFileEditor.java

Lines 336 to 351 in 5a472fb

	Display.getDefault( ).asyncExec( new Runnable( ) {
	public void run( )
	{
	JavaDecompilerClassFileEditor.this.getEditorSite( )
	.getPage( )
	.closeEditor( JavaDecompilerClassFileEditor.this,
	false );
	}
	} );
	throw new CoreException( new Status( 8,
	JavaDecompilerPlugin.PLUGIN_ID,
	1,
	"", //$NON-NLS-1$
	null ) );

To me it looks like there is a return statement missing so the section with closeEditor and the CoreExcpetion is never called.