Skip to content

Consider removing Debug trait on Biscuit #256

@outscale-fba

Description

@outscale-fba

Debug & Display Trait are very verbose by default.

This can easily lead to leaks of biscuit content in logs, for example if a biscuit is passed to an instrumented function with the tracing crate.

For example:

#[tracing::instrument]
pub fn handler(biscuit: Biscuit) { ... }

will include the biscuit debug output in the traces & logs.

Note: This can be avoided by ignoring the biscuit using #[tracing::instrument(skip(biscuit))], but this is quite fragile (easy to forget the skip option).
Note: Display impl was introduced by #117

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions