Errors in glassfish/config/config.bat

[franzl-hansel]

GlassFish Version (and build number)

7.0.25 / 7.1 / 8.0

JDK version

21

OS

Windows 11

Database

No response

Problem Description

There are a couple of issues in glassfish/config/config.bat:

1. Line 33: %AS_INTSTALL%\config should be enclosed within quotation marks, in order to handle paths containing parentheses
2. Line 48: The semicolon in JAVA=%%~$PATH;i should be a colon

Steps to reproduce

Run the following batch script:

@echo off
set "AS_INSTALL=C:\Users\BillGates(Microsoft)\glassfish7"

if exist "%AS_INSTALL%\config\asenv.bat" (
    call "%AS_INSTALL%\config\asenv.bat"
) else (
    echo Error: asenv.bat not found in %AS_INSTALL%\config
)

for %%i in (java.exe) do set "JAVA=%%~$PATH;i"
echo %JAVA%

Whereas the following does work:

@echo off
set "AS_INSTALL=C:\Users\BillGates(Microsoft)\glassfish7"

if exist "%AS_INSTALL%\config\asenv.bat" (
    call "%AS_INSTALL%\config\asenv.bat"
) else (
    echo Error: asenv.bat not found in "%AS_INSTALL%\config"
)

for %%i in (java.exe) do set "JAVA=%%~$PATH:i"
echo %JAVA%

Impact of Issue

Requires manual correction of the file.

[OndroMih]

Hello, @franzl-hansel , thank you for reporting this.

Can you explain why "The semicolon in JAVA=%%~$PATH;i should be a colon" ? I think that Windows uses semicolons as path separator in the PATH variable, doesn't it? (I'm not currently at a Windows machine to test this)

[franzl-hansel]

Hello @OndroMih. You're right that ; is the path separator on Windows, but %~$PATH:i is the parameter modifier that automatically splits on the path separator.

Cf: https://ss64.com/nt/syntax-args.html

[OndroMih]

Thank you, I understand now. The for cycle exists only to set an indexed parameter with the value of java.exe and find first executable that matches the PATH variable. The syntax couldn't be any more weird. In Linux, it's the same is done simply by which java.

[dmatej]

@franzl-hansel We have automated tests for this, would you find time to update them and fix it as a contribution? Ie. PathWithSpacesITest

Basically you could just add parenthesses or some other common but "hostile" characters to the gfRootWithSpaces variable, and we could have a reproducer ...