Skip to content

refactor nodeagent: container info reporting#123

Merged
youngtaekiim merged 2 commits into
eclipse-pullpiri:refactoringfrom
daeyoung-jeong-lge:refactoring
Jul 15, 2025
Merged

refactor nodeagent: container info reporting#123
youngtaekiim merged 2 commits into
eclipse-pullpiri:refactoringfrom
daeyoung-jeong-lge:refactoring

Conversation

@daeyoung-jeong-lge
Copy link
Copy Markdown
Contributor

url: #122
desc : Refactor NodeAgent for container info reporting. compile test OK. cargo test OK. cargo run OK

  • Implemented container inspection functionality in resource module.
  • Refactored receiver and sender modules to align with new monitoring server structure.
  • Updated Cargo.toml to include new dependencies: futures, hyper, hyperlocal, and thiserror.
  • Modified Cargo.lock to reflect updated versions of http and http-body.
  • Removed unused monitoringclient.proto and replaced it with monitoringserver.proto.

- Implemented container inspection functionality in resource module.
- Refactored receiver and sender modules to align with new monitoring server structure.
- Updated Cargo.toml to include new dependencies: futures, hyper, hyperlocal, and thiserror.
- Modified Cargo.lock to reflect updated versions of http and http-body.
- Removed unused monitoringclient.proto and replaced it with monitoringserver.proto.
Comment thread src/agent/nodeagent/src/resource/mod.rs
Comment thread src/agent/nodeagent/src/manager.rs
@youngtaekiim youngtaekiim self-assigned this Jul 15, 2025
- update hostname retrieval in NodeAgentManager
- modify socket path comments
Copy link
Copy Markdown
Contributor Author

@daeyoung-jeong-lge daeyoung-jeong-lge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied the feedbacks to my code. Please review again.

Comment thread src/agent/nodeagent/src/manager.rs
Comment thread src/agent/nodeagent/src/resource/mod.rs
@youngtaekiim youngtaekiim merged commit 77c16a6 into eclipse-pullpiri:refactoring Jul 15, 2025
5 of 6 checks passed
@youngtaekiim youngtaekiim linked an issue Jul 15, 2025 that may be closed by this pull request
chaehee-lim pushed a commit to chaehee-lim/pullpiri that referenced this pull request Sep 3, 2025
- update hostname retrieval in NodeAgentManager
- modify socket path comments
chaehee-lim pushed a commit to chaehee-lim/pullpiri that referenced this pull request Sep 3, 2025
…ring

refactor nodeagent: container info reporting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] Refactor NodeAgent for container info reporting

2 participants