[Task] Implement of connecting between actioncontroller and pharos #144#145
Merged
youngtaekiim merged 3 commits intoJul 28, 2025
Merged
Conversation
desc : implement of connecting between actioncontroller and pharos for milestone2. compile test Ok. Add Node spec in common/spec/artifact. Add pharos_service proto To parse the node in api-server, add the node area. Implement request_network_pod method to send data(node, network, pod_name) to the pharos via gRPC. Implement complete_network_setting method to receive a CompleteNetworkSettingResponse from the pharos via gRPC.
| message CompleteNetworkSettingRequest { | ||
| string request_id = 1; | ||
| enum Status { | ||
| OK = 0; |
Contributor
There was a problem hiding this comment.
Status 를 밖으로 빼고 이름 바꾸고, 원래 있던 Status 도 이름 바꿔서 혼동 방지
Contributor
Author
There was a problem hiding this comment.
네 수정하여 반영하도록 하겠습니다.
desc : actionController status name change to prevent confusion. compile test Ok.
youngtaekiim
approved these changes
Jul 28, 2025
youngtaekiim
merged commit 28f1223
into
eclipse-pullpiri:refactoring
5 of 6 checks passed
chaehee-lim
pushed a commit
to chaehee-lim/pullpiri
that referenced
this pull request
Sep 3, 2025
desc : actionController status name change to prevent confusion. compile test Ok.
chaehee-lim
pushed a commit
to chaehee-lim/pullpiri
that referenced
this pull request
Sep 3, 2025
[Task] Implement of connecting between actioncontroller and pharos eclipse-pullpiri#144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url: #144
desc : implement of connecting between actioncontroller and pharos for milestone2. compile test Ok.
Add Node spec in common/spec/artifact.
Add pharos_service proto
To parse the node in api-server, add the node area.
Implement request_network_pod method to send data(node, network, pod_name) to the pharos via gRPC.
Implement complete_network_setting method to receive a CompleteNetworkSettingResponse from the pharos via gRPC.