Skip to content

Adding missing .yml file for github workflow#147

Merged
youngtaekiim merged 1 commit into
eclipse-pullpiri:mainfrom
akshaylg0314:CD_PIPELINE
Jul 29, 2025
Merged

Adding missing .yml file for github workflow#147
youngtaekiim merged 1 commit into
eclipse-pullpiri:mainfrom
akshaylg0314:CD_PIPELINE

Conversation

@akshaylg0314
Copy link
Copy Markdown
Contributor

Adding missing .yml file for github workflow

@akshaylg0314
Copy link
Copy Markdown
Contributor Author

Hey @youngtaekiim I added one missing workflow file which is missing in release workflow
Please add this also,Sorry for the confusion and this missing workflow file.
Thanks!!

@youngtaekiim youngtaekiim self-requested a review July 29, 2025 05:58
@youngtaekiim youngtaekiim merged commit 35781ef into eclipse-pullpiri:main Jul 29, 2025
6 checks passed
@akshaylg0314
Copy link
Copy Markdown
Contributor Author

@youngtaekiim Clippy lint check is failling for two components:
Actioncontroller:
error: could not compile actioncontroller (bin "actioncontroller" test) due to 3 previous errors; 22 warnings emitted
Error: ❌ Clippy for actioncontroller failed! Found warnings/errors.
Error: 🚨 Clippy failed for 2 component(s).
Error: Process completed with exit code 1.

Filtergateway:
warning: filtergateway (bin "filtergateway" test) generated 37 warnings (35 duplicates)
error: could not compile filtergateway (bin "filtergateway" test) due to 1 previous error; 37 warnings emitted
Error: ❌ Clippy for filtergateway failed! Found warnings/errors.

@youngtaekiim
Copy link
Copy Markdown
Contributor

@youngtaekiim Clippy lint check is failling for two components: Actioncontroller: error: could not compile actioncontroller (bin "actioncontroller" test) due to 3 previous errors; 22 warnings emitted Error: ❌ Clippy for actioncontroller failed! Found warnings/errors. Error: 🚨 Clippy failed for 2 component(s). Error: Process completed with exit code 1.

Filtergateway: warning: filtergateway (bin "filtergateway" test) generated 37 warnings (35 duplicates) error: could not compile filtergateway (bin "filtergateway" test) due to 1 previous error; 37 warnings emitted Error: ❌ Clippy for filtergateway failed! Found warnings/errors.

Does cippy_check.sh need to no warning/error in cargo clippy result?

@akshaylg0314
Copy link
Copy Markdown
Contributor Author

akshaylg0314 commented Jul 29, 2025

@youngtaekiim Clippy lint check is failling for two components: Actioncontroller: error: could not compile actioncontroller (bin "actioncontroller" test) due to 3 previous errors; 22 warnings emitted Error: ❌ Clippy for actioncontroller failed! Found warnings/errors. Error: 🚨 Clippy failed for 2 component(s). Error: Process completed with exit code 1.
Filtergateway: warning: filtergateway (bin "filtergateway" test) generated 37 warnings (35 duplicates) error: could not compile filtergateway (bin "filtergateway" test) due to 1 previous error; 37 warnings emitted Error: ❌ Clippy for filtergateway failed! Found warnings/errors.

Does cippy_check.sh need to no warning/error in cargo clippy result?

NO Its not required i made the chnages in actioncontroller and Filtergateway for clippy check
Clipy check is failling because of code changes some of test cases required to be modified

I made format check also
Format check also failing for agent and actioncontroller

I think below action will pass for all checks
https://github.com/eclipse-pullpiri/pullpiri/actions/runs/16589314170

@youngtaekiim
Copy link
Copy Markdown
Contributor

@youngtaekiim Clippy lint check is failling for two components: Actioncontroller: error: could not compile actioncontroller (bin "actioncontroller" test) due to 3 previous errors; 22 warnings emitted Error: ❌ Clippy for actioncontroller failed! Found warnings/errors. Error: 🚨 Clippy failed for 2 component(s). Error: Process completed with exit code 1.
Filtergateway: warning: filtergateway (bin "filtergateway" test) generated 37 warnings (35 duplicates) error: could not compile filtergateway (bin "filtergateway" test) due to 1 previous error; 37 warnings emitted Error: ❌ Clippy for filtergateway failed! Found warnings/errors.

Does cippy_check.sh need to no warning/error in cargo clippy result?

NO Its not required i made the chnages in actioncontroller and Filtergateway for clippy check Clipy check is failling because of code changes some of test cases required to be modified

I made format check also Format check also failing for agent and actioncontroller

I think below action will pass for all checks https://github.com/eclipse-pullpiri/pullpiri/actions/runs/16589314170

yes, i found a new PR pass all checks.

chaehee-lim pushed a commit to chaehee-lim/pullpiri that referenced this pull request Sep 3, 2025
Adding missing .yml file for github workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants