test(api):Unit test cases for Nodeagent Module[#153]#154
Merged
Conversation
6 tasks
Contributor
Author
|
@youngtaekiim please review the changes |
youngtaekiim
reviewed
Aug 5, 2025
Contributor
|
I only comment one about shell script, please answer it. It's difficult to review all unit test code. |
Contributor
Author
I will attach the test report and code coverage report also soon |
Contributor
Author
|
Hey @youngtaekiim i attached the reports for unit tests and code coverage in the descripton section of this PR, i reverted the chnages for helloworld.sh as well |
youngtaekiim
approved these changes
Aug 5, 2025
chaehee-lim
pushed a commit
to chaehee-lim/pullpiri
that referenced
this pull request
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(api):Unit test cases for Nodeagent Module[#153]
Unit test report:
running 36 tests
test bluechi::filemaker::tests::test_directory_creation ... ok
test bluechi::filemaker::tests::test_make_kube_file_invalid_dir ... ok
test bluechi::parser::tests::test_get_complete_model_invalid_yaml ... ok
test bluechi::filemaker::tests::test_make_kube_file ... ok
test bluechi::parser::tests::test_get_complete_model_missing_models ... ok
test bluechi::filemaker::tests::test_make_yaml_file_invalid_dir ... ok
test bluechi::test::test_parse_with_empty_yaml ... ok
test bluechi::filemaker::tests::test_make_yaml_file ... ok
test bluechi::test::test_parse_with_invalid_yaml_format ... ok
test grpc::receiver::tests::test_handle_yaml_send_error ... ok
test bluechi::test::test_parse_with_missing_models_section ... ok
test grpc::receiver::tests::test_handle_yaml_with_valid_artifact_yaml ... ok
test bluechi::parser::tests::test_get_complete_model_success ... ok
test bluechi::parser::tests::test_get_complete_model_missing_network ... ok
test bluechi::test::test_parse_with_valid_artifact_yaml ... ok
test manager::tests::test_initialize_returns_ok ... ok
test manager::tests::test_new_creates_instance_with_correct_hostname ... ok
test grpc::sender::tests::test_send_changed_container_list_error_propagation ... ok
test manager::tests::test_process_grpc_requests_handles_empty_channel ... ok
test bluechi::parser::tests::test_get_complete_model_missing_volume ... ok
test grpc::sender::tests::test_trigger_action_success ... ok
test manager::tests::test_process_grpc_requests_receives_and_parses_yaml ... ok
test grpc::sender::tests::test_send_container_list_error_propagation ... ok
test grpc::sender::tests::test_trigger_action_multiple_calls ... ok
test bluechi::parser::tests::test_volume_and_network_resolution ... ok
test resource::container::tests::test_get_inspect_invalid_id ... ok
test resource::container::tests::test_inspect_contains_expected_keys ... ok
test tests::test_main_initializes_channels ... ok
test resource::container::tests::test_inspect_env_var_hostname_default ... ok
test resource::container::tests::test_get_inspect_success ... ok
test resource::container::tests::test_inspect_env_var_hostname ... ok
test resource::container::tests::test_get_list_success ... ok
test tests::test_inspect ... ok
test tests::test_main_launch_manager ... ok
test resource::tests::test_get_with_valid_path ... ok
test bluechi::filemaker::tests::test_make_files_from_pod ... ok
test result: ok. 36 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.00s
Code Coverage report:
test result: ok. 36 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.00s
2025-08-05T08:23:00.866109Z INFO cargo_tarpaulin::report: Coverage Results:
|| Uncovered Lines:
|| nodeagent/src/bluechi/filemaker.rs: 21
|| nodeagent/src/bluechi/parser.rs: 29, 51, 98
|| nodeagent/src/grpc/receiver.rs: 26
|| nodeagent/src/main.rs: 30, 33-34, 42, 46, 49, 51-52, 54, 58, 60-63
|| nodeagent/src/manager.rs: 76, 90, 96, 102, 105-109, 111, 113, 129, 137-138
|| nodeagent/src/resource/container.rs: 23-32, 34-40, 42-49, 51-53, 55-57, 59-62, 64-66, 68-69, 71-72, 74, 77-83, 88, 113
|| Tested/Total Lines:
|| nodeagent/src/bluechi/filemaker.rs: 37/38
|| nodeagent/src/bluechi/mod.rs: 7/7
|| nodeagent/src/bluechi/parser.rs: 45/48
|| nodeagent/src/grpc/receiver.rs: 8/9
|| nodeagent/src/grpc/sender.rs: 16/16
|| nodeagent/src/main.rs: 5/19
|| nodeagent/src/manager.rs: 33/47
|| nodeagent/src/resource/container.rs: 13/65
|| nodeagent/src/resource/mod.rs: 6/6
||
66.67% coverage, 170/255 lines covered