Fix CI Dispatcher failures and revert workload deployment changes for unknown nodes#164
Fix CI Dispatcher failures and revert workload deployment changes for unknown nodes#164Copilot wants to merge 4 commits into
Conversation
|
@Chulhee1Lee 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
|
현재 Copilot Coding Agent를 활용해서 테스트를 진행해보고 있습니다. |
… setup Co-authored-by: Chulhee1Lee <104404644+Chulhee1Lee@users.noreply.github.com>
|
@youngtaekiim, @leeeunkoo |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a workload deployment issue in multi-node BlueChI setups where workloads targeting unconfigured nodes were silently skipped instead of being deployed. The fix changes the behavior to default unconfigured nodes to "bluechi" type with warning messages for better visibility.
- Changed
continuestatements to default unconfigured nodes to "bluechi" type instead of skipping - Added warning messages to help identify configuration gaps
- Maintained backward compatibility without breaking existing configurations
|
@copilot CI Dispatcher Fail 발생하는 문제를 해결해라. |
Co-authored-by: Chulhee1Lee <104404644+Chulhee1Lee@users.noreply.github.com>
I've fixed the CI Dispatcher failure. The issue was that essential dependencies ( The fix is in commit 5c42366 - the build should now pass successfully. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…defaulting to bluechi Co-authored-by: Chulhee1Lee <104404644+Chulhee1Lee@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot PR Commit들이 모두 너로 작성자가 되어 있어서 Eclipse Contributor Agreement 문제로 merge가 안되고 있어. PR Commit 작성자 이름을 내 이름으로 바꿔서 eclipsefdn/eca 통과되도록 만들어줘. |
I understand the ECA issue with the commit authorship. Unfortunately, I cannot change commit authors as it requires rewriting git history with force push, which I don't have access to. You'll need to manually change the commit authors using: git rebase -i HEAD~4
# For each commit, change 'pick' to 'edit'
# Then for each commit: git commit --amend --author="Your Name <your.email@example.com>"
# Continue with: git rebase --continue
# Finally: git push --force-with-leaseAlternatively, you could create a new branch with fresh commits using the same changes but with your authorship. |
|
Fork하여 수정 후 다시 Pull Request 하도록 하겠습니다. |
본 PR은 #187 로 대체됩니다.
This PR fixes CI Dispatcher failures and reverts the workload deployment behavior for unknown nodes based on reviewer feedback.
Problem 1: CI Dispatcher Failures
The CI workflow was failing because essential dependencies (
protobuf-compiler,libdbus-1-dev,pkg-config) were not available before Rust compilation began, causing build failures.Solution: Updated the CI workflow to:
actions-rs/toolchain@v1with moderndtolnay/rust-toolchain@stableProblem 2: Unknown Node Handling
Based on reviewer feedback, the approach to handle unknown nodes in multi-node BlueChI configurations has been reverted to the original behavior of skipping them entirely, but with added logging for better debugging.
Previous behavior: Unknown nodes were skipped silently with
continueAttempted fix: Unknown nodes were defaulted to "bluechi" type to enable deployment
Current behavior: Unknown nodes are skipped with warning logs for visibility
This maintains the original safety behavior while providing better observability when workloads fail to deploy due to unconfigured nodes.
Testing
Fixes #163.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.