Unknown Node Handling Issue Fix ( not launch workload at worker node )#187
Conversation
… setup Co-authored-by: Chulhee1Lee <104404644+Chulhee1Lee@users.noreply.github.com>
Co-authored-by: Chulhee1Lee <104404644+Chulhee1Lee@users.noreply.github.com>
…defaulting to bluechi Co-authored-by: Chulhee1Lee <104404644+Chulhee1Lee@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the handling of unknown nodes in multi-node BlueChI configurations to the original behavior of skipping them entirely, while adding warning logs for better debugging visibility. The change addresses workload deployment issues where unknown nodes were being processed incorrectly.
- Reverted unknown node handling from defaulting to "bluechi" type back to skipping with
continue - Added warning log messages when unknown nodes are encountered to improve debugging
- Updated CI workflow to install essential dependencies and use a more current Rust toolchain action
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/player/actioncontroller/src/manager.rs | Reverted unknown node handling to skip with warning logs and added test for node categorization |
| .github/workflows/run-ci.yml | Updated CI dependencies and Rust toolchain installation method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@akshaylg0314 Please review and help to fix CI Issues. |
Hey @Chulhee1Lee, sorry for the late reply — I was on leave yesterday. Next time, before merging code, we just need to run cargo fmt in the root of each component. That should resolve the issue. |
Unknown Node Handling Issue Fix ( not launch workload at worker node )
Unknown Node Handling
Based on reviewer feedback, the approach to handle unknown nodes in multi-node BlueChI configurations has been reverted to the original behavior of skipping them entirely, but with added logging for better debugging.
Previous behavior: Unknown nodes were skipped silently with
continueAttempted fix: Unknown nodes were defaulted to "bluechi" type to enable deployment
Current behavior: Unknown nodes are skipped with warning logs for visibility
This maintains the original safety behavior while providing better observability when workloads fail to deploy due to unconfigured nodes.
Testing
Fixes #163.
Pull Request Overview
This PR fixes a workload deployment issue in multi-node BlueChI setups where workloads targeting unconfigured nodes were silently skipped instead of being deployed. The fix changes the behavior to default unconfigured nodes to "bluechi" type with warning messages for better visibility.
continuestatements to default unconfigured nodes to "bluechi" type instead of skipping