Skip to content

Unknown Node Handling Issue Fix ( not launch workload at worker node )#187

Merged
youngtaekiim merged 4 commits into
eclipse-pullpiri:mainfrom
Chulhee1Lee:main
Aug 18, 2025
Merged

Unknown Node Handling Issue Fix ( not launch workload at worker node )#187
youngtaekiim merged 4 commits into
eclipse-pullpiri:mainfrom
Chulhee1Lee:main

Conversation

@Chulhee1Lee
Copy link
Copy Markdown
Contributor

@Chulhee1Lee Chulhee1Lee commented Aug 14, 2025

Unknown Node Handling

Based on reviewer feedback, the approach to handle unknown nodes in multi-node BlueChI configurations has been reverted to the original behavior of skipping them entirely, but with added logging for better debugging.

Previous behavior: Unknown nodes were skipped silently with continue
Attempted fix: Unknown nodes were defaulted to "bluechi" type to enable deployment
Current behavior: Unknown nodes are skipped with warning logs for visibility

} else {
    // Log warning for unknown node types and skip processing
    println!("Warning: Node '{}' is not explicitly configured. Skipping deployment.", model_node);
    continue;
};

This maintains the original safety behavior while providing better observability when workloads fail to deploy due to unconfigured nodes.

Testing

  • CI workflow now passes without dependency issues
  • All existing manager tests continue to pass
  • Added warning logs help with debugging deployment issues for unknown nodes

Fixes #163.

Pull Request Overview

This PR fixes a workload deployment issue in multi-node BlueChI setups where workloads targeting unconfigured nodes were silently skipped instead of being deployed. The fix changes the behavior to default unconfigured nodes to "bluechi" type with warning messages for better visibility.

  • Changed continue statements to default unconfigured nodes to "bluechi" type instead of skipping
  • Added warning messages to help identify configuration gaps
  • Maintained backward compatibility without breaking existing configurations

Chulhee1Lee and others added 4 commits August 14, 2025 10:20
… setup

Co-authored-by: Chulhee1Lee <104404644+Chulhee1Lee@users.noreply.github.com>
Co-authored-by: Chulhee1Lee <104404644+Chulhee1Lee@users.noreply.github.com>
…defaulting to bluechi

Co-authored-by: Chulhee1Lee <104404644+Chulhee1Lee@users.noreply.github.com>
@Chulhee1Lee Chulhee1Lee self-assigned this Aug 14, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the handling of unknown nodes in multi-node BlueChI configurations to the original behavior of skipping them entirely, while adding warning logs for better debugging visibility. The change addresses workload deployment issues where unknown nodes were being processed incorrectly.

  • Reverted unknown node handling from defaulting to "bluechi" type back to skipping with continue
  • Added warning log messages when unknown nodes are encountered to improve debugging
  • Updated CI workflow to install essential dependencies and use a more current Rust toolchain action

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/player/actioncontroller/src/manager.rs Reverted unknown node handling to skip with warning logs and added test for node categorization
.github/workflows/run-ci.yml Updated CI dependencies and Rust toolchain installation method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/player/actioncontroller/src/manager.rs
Comment thread src/player/actioncontroller/src/manager.rs
@Chulhee1Lee
Copy link
Copy Markdown
Contributor Author

@akshaylg0314 Please review and help to fix CI Issues.

@youngtaekiim youngtaekiim merged commit 8f28088 into eclipse-pullpiri:main Aug 18, 2025
5 of 6 checks passed
@akshaylg0314
Copy link
Copy Markdown
Contributor

@akshaylg0314 Please review and help to fix CI Issues.

Hey @Chulhee1Lee, sorry for the late reply — I was on leave yesterday.
The CI pipeline failed due to a cargo fmt check in one of the components.

Next time, before merging code, we just need to run cargo fmt in the root of each component. That should resolve the issue.
thanks!!

chaehee-lim pushed a commit to chaehee-lim/pullpiri that referenced this pull request Sep 3, 2025
Unknown Node Handling Issue Fix ( not launch workload at worker node )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[issue] not launch workload at worker node(multi node not master)

5 participants