Use RAP with org.osgi.service.http.HttpService

[kenwenzel]

I've just upgraded to RAP 4.7.0 and I don't find a solution how to register the required servlet/filter with a default org.osgi.service.http.HttpService.
It seems that I have to somehow use HttpServiceFactory with an appropriate HttpServiceRuntimeImpl.

I'm using Equinox together with org.apache.felix.http.jetty12_2.0.0.

Any help is greatly appreciated!

Best regards,
Ken

[ifurnadjiev]

It's exactly the same, like in RAP 3.x, but you have to use the new bundle org.eclipse.rap.http.servlet and org.eclipse.rap.service.http.HttpService.

[kenwenzel]

Thank you for the quick reply. In my case Jetty 12 is already started via org.apache.felix.http.jetty12_2.0.0 which also implements the (javax.* based) org.osgi.service.http.HttpService and a jakarta.* based OSGi HTTP Whiteboard implementation.

If I undestand it correctly then org.eclipse.rap.http.servlet provides an updated HttpService for jakarta servlets and also a whiteboard implementation.

My first try is to provide an own wrapper implementation of RAP's HttpService:

package net.enilink.platform.workbench.components;

import jakarta.servlet.Servlet;
import jakarta.servlet.ServletException;
import org.apache.felix.http.jakartawrappers.HttpServletRequestWrapper;
import org.apache.felix.http.jakartawrappers.HttpServletResponseWrapper;
import org.apache.felix.http.javaxwrappers.ServletWrapper;
import org.eclipse.rap.service.http.HttpContext;
import org.eclipse.rap.service.http.NamespaceException;
import org.osgi.service.component.annotations.Component;
import org.osgi.service.component.annotations.Reference;
import org.osgi.service.http.HttpService;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import java.io.IOException;
import java.net.URL;
import java.util.Dictionary;
import java.util.Objects;

@Component(immediate = true)
public class RapHttpService implements org.eclipse.rap.service.http.HttpService {
	static class RapOsgiHttpContextWrapper implements org.osgi.service.http.HttpContext {
		final HttpContext delegate;

		RapOsgiHttpContextWrapper(HttpContext delegate) {
			this.delegate = delegate;
		}

		@Override
		public boolean handleSecurity(HttpServletRequest request, HttpServletResponse response) throws IOException {
			return delegate.handleSecurity(new HttpServletRequestWrapper(request), new HttpServletResponseWrapper(response));
		}

		@Override
		public URL getResource(String name) {
			return delegate.getResource(name);
		}

		@Override
		public String getMimeType(String name) {
			return delegate.getMimeType(name);
		}

		@Override
		public boolean equals(Object o) {
			if (o == null || getClass() != o.getClass()) return false;
			RapOsgiHttpContextWrapper that = (RapOsgiHttpContextWrapper) o;
			return Objects.equals(delegate, that.delegate);
		}

		@Override
		public int hashCode() {
			return Objects.hashCode(delegate);
		}
	}

	static class OsgiRapHttpContextWrapper implements HttpContext {
		final org.osgi.service.http.HttpContext delegate;

		OsgiRapHttpContextWrapper(org.osgi.service.http.HttpContext delegate) {
			this.delegate = delegate;
		}

		@Override
		public boolean handleSecurity(jakarta.servlet.http.HttpServletRequest request, jakarta.servlet.http.HttpServletResponse response) throws IOException {
			return delegate.handleSecurity(new org.apache.felix.http.javaxwrappers.HttpServletRequestWrapper(request), new org.apache.felix.http.javaxwrappers.HttpServletResponseWrapper(response));
		}

		@Override
		public URL getResource(String name) {
			return delegate.getResource(name);
		}

		@Override
		public String getMimeType(String name) {
			return delegate.getMimeType(name);
		}

		@Override
		public boolean equals(Object o) {
			if (o == null || getClass() != o.getClass()) return false;
			OsgiRapHttpContextWrapper that = (OsgiRapHttpContextWrapper) o;
			return Objects.equals(delegate, that.delegate);
		}

		@Override
		public int hashCode() {
			return Objects.hashCode(delegate);
		}
	}

	@Reference
	protected HttpService httpService;

	@Override
	public void registerServlet(String alias, Servlet servlet, Dictionary<?, ?> initparams, HttpContext context) throws ServletException, NamespaceException {
		try {
			httpService.registerServlet(alias, new ServletWrapper(servlet), initparams, new RapOsgiHttpContextWrapper(context));
		} catch (javax.servlet.ServletException e) {
			throw new ServletException(e);
		} catch (org.osgi.service.http.NamespaceException e) {
			throw new NamespaceException(e.getMessage());
		}
	}

	@Override
	public void registerResources(String alias, String name, HttpContext context) throws NamespaceException {
		try {
			httpService.registerResources(alias, name, new RapOsgiHttpContextWrapper(context));
		} catch (org.osgi.service.http.NamespaceException e) {
			throw new NamespaceException(e.getMessage());
		}
	}

	@Override
	public void unregister(String alias) {
		httpService.unregister(alias);
	}

	@Override
	public HttpContext createDefaultHttpContext() {
		return new OsgiRapHttpContextWrapper(httpService.createDefaultHttpContext());
	}
}

Is there anything more simple to connect RAP with an existing OSGi HTTP Whiteboard service?

[kenwenzel]

@ifurnadjiev The fix above is working for me. But it would be simpler if RAP would use OSGi HTTP whiteboard to register the RWTServlet.