fix: clear Sphinx-Needs defaults

Author: a-zw

src/extensions/score_metamodel/__init__.py

@@ -291,6 +291,26 @@ def postprocess_need_links(needs_types_list: list[ScoreNeedType]):
                 )
 
 
+def _clear_needs_defaults(app: Sphinx):
+    """Clear default need types, links and fields provided by sphinx-needs.
+
+    This ensures that only the need types defined in our metamodel are used,
+    and prevents issues where the defaults get merged with our types and cause
+    unexpected behavior.
+    """
+    default_directives = {"need", "req", "spec", "impl", "test"}
+    existing_directives = {nt["directive"] for nt in app.config.needs_types}
+    if existing_directives == default_directives:
+        app.config.needs_types.clear()
+        logger.info("Cleared default Sphinx-Needs types: %s", default_directives)
+    else:
+        logger.info(
+            f"Expected default need types {default_directives} not found. "
+            "Not clearing needs_types to avoid accidentally removing custom types. "
+            f"Existing directives: {existing_directives}"
+        )
+
+
 def setup(app: Sphinx) -> dict[str, str | bool]:
     app.add_config_value("external_needs_source", "", rebuild="env")
     app.add_config_value("score_metamodel_yaml", "", rebuild="env")
@@ -303,6 +323,7 @@ def setup(app: Sphinx) -> dict[str, str | bool]:
     metamodel = load_metamodel_data(override_path)
 
     # Extend sphinx-needs config rather than overwriting
+    _clear_needs_defaults(app)
     app.config.needs_types += metamodel.needs_types
     app.config.needs_links.update(metamodel.needs_links)
     app.config.needs_fields.update(metamodel.needs_fields)