Skip to content

Commit bec77ef

Browse files
committed
Fix review findings
1 parent f0e940c commit bec77ef

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

docs.bzl

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,17 +57,14 @@ def _rewrite_needs_json_to_docs_sources(labels):
5757
return out
5858

5959
def _rewrite_needs_json_to_sourcelinks(labels):
60-
"""Replace '@repo//:needs_json' -> '@repo//:sourcelinks_json' for every item.
61-
Note: Else path has been commented out as this prevented inclusion of CPP files
62-
for case when fragment of code shall be displayed as literal include.
63-
"""
60+
"""Replace '@repo//:needs_json' -> '@repo//:sourcelinks_json' for every item."""
6461
out = []
6562
for x in labels:
6663
s = str(x)
6764
if s.endswith("//:needs_json"):
6865
out.append(s.replace("//:needs_json", "//:sourcelinks_json"))
69-
#else:
70-
#out.append(s)
66+
#Items which do not end up with '//:needs_json' shall not be appended to 'out'.
67+
#They are treated separately and are not related to source code linking.
7168
return out
7269

7370
def _merge_sourcelinks(name, sourcelinks, known_good = None):

0 commit comments

Comments
 (0)